| 18 Mar 2025 |
 Kevin Mittman (EOY sleep) | TRT 10.3 is pretty old | 18:17:09 |
 stick | Michal Koutenský: i recommend you to use CUDA stuff from master/nixpkgs-unstable - many fixes go there and are not being backported to stable (24.11) | 18:35:39 |
| stick | for example I updated TRT to 10.8 there (and there is already 10.9, yay) | 18:36:04 |
| stick | btw, zdravim do Brna :D | 18:36:36 |
 Michal Koutenský | does the python package build though? i checked master (and issues/prs) yesterday and there doesn't seem to be anything significant https://github.com/NixOS/nixpkgs/commits/master/pkgs/development/python-modules/tensorrt/default.nix | 18:37:19 |
| Michal Koutenský | i guess i'll try building master and possibly move our stuff off 24.11 | 18:37:42 |
| Michal Koutenský | a Brno zdraví naspäť :D | 18:37:53 |
| stick | i updated the package here https://github.com/NixOS/nixpkgs/commit/1609398c9def5a31bb7951c284cf21f45b981b39
the python-module is just a simple wrapper that does not need changes i guess | 18:38:45 |
| Michal Koutenský | well the issue is with the preUnpack, which tries to get the wheel by a wrong name, at leas in my case | 18:39:26 |
| stick | try it with unstable - if it works great - if it does not work, please open an issue and tag me in the comment | 18:41:26 |
| Michal Koutenský | yup, will do that | 18:41:59 |
| Michal Koutenský | so, unstable with 10.8.0.43 builds and the tarball has the full 4 part version number in the filenames, 10.3.0.26 has a 3 part version number which breaks the build | 19:34:29 |
| Kevin Mittman (EOY sleep) | often the build number field is dropped from release label version (also # of fields is subject to change) | 19:38:17 |
| Michal Koutenský | then this is not really reliable is it? https://github.com/NixOS/nixpkgs/blob/59b1aef59071cae6e87859dc65de973d2cc595c0/pkgs/development/python-modules/tensorrt/default.nix#L33 | 19:40:09 |
| stick | well it is not, but also i think it is a bug in nvidia packaging, so hopefully it won't happen anymore | 19:59:10 |
| stick | looking at pypi - https://pypi.org/project/tensorrt/#history - it seems they are following the scheme where they add the build number to the pypi version | 20:00:20 |
| stick | might be worth adding code that uses only a.b.c instead of a.b.c.d for versions <10.8 | 20:00:57 |
| Michal Koutenský | i tried listing the archive and grepping for cpXY and tensorrt- but that's quite slow unfortunately | 20:01:51 |
| stick | looking at versions of tensorrt and pypi - only these two are affected:
8.6.1.6 vs 8.6.1
10.3.0.26 vs 10.3.0 | 20:03:39 |
| stick | because 8.5.3.1 uses the same version in pypy (including the .1) and older versions are not present on pypi at all | 20:04:37 |
| Michal Koutenský | guess i can submit a PR that conditionally changes the filename for those two | 20:06:15 |
| Michal Koutenský | thanks for your help! | 20:06:40 |
| stick | that would work, ping me in the PR, thanks | 20:07:02 |
| stick | you would just override the version here:
https://github.com/NixOS/nixpkgs/blob/59b1aef59071cae6e87859dc65de973d2cc595c0/pkgs/development/python-modules/tensorrt/default.nix#L16 | 20:07:24 |
| Michal Koutenský | not in the unpack phase? | 20:07:53 |
| stick | i guess the question is what version is being reported by the wheel | 20:09:08 |
| stick | try calling
import tensorrt
print(tensorrt.version)
| 20:10:01 |
| stick | * try calling
import tensorrt
print(tensorrt.__version__)
| 20:10:10 |
| stick | or
import tensorrt
from importlib.metadata import version
version('tensorrt')
| 20:11:00 |
| stick | if you are feeling adventurous, you might as well update pkgs/development/cuda-modules/tensorrt/releases.nix to contain the latest 10.9.x.y release | 20:12:02 |
