9 May 2025 |
connor (he/him) (UTC-7) | Gaétan Lepage: any chance you'd be able to look at this? I'd like to get it merged soon since things depending on cuDNN (like PyTorch) are broken on x86_64-linux . | 21:22:03 |
Gaétan Lepage | I started to look at it but got scared by the nature of the diff | 21:22:53 |
Gaétan Lepage | Will look at it :) | 21:22:58 |
connor (he/him) (UTC-7) | <3 | 21:23:01 |
connor (he/him) (UTC-7) | If it helps at all, the evaluatedModules.config.${pname}.releases.${redistArch} attribute set we're indexing into is essentially just the releases.nix file each of the multiplexed packages provides (for example, here's cuDNN's: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/cuda-modules/cudnn/releases.nix). | 21:26:01 |
connor (he/him) (UTC-7) | The call to lib.foldl' inside newestPackages traverses the list of package (the elements of the list of attribute sets underneath each architecture in releases.nix ), keeping the latest copy of each major-minor version. | 21:28:59 |
Gaétan Lepage | Yes, I got a broad idea of what was happening | 21:30:20 |
Gaétan Lepage | Anyway, should be good to merge | 21:30:36 |
Gaétan Lepage | Subsidiary question: any reason for using lib.map instead of builtins.map ? | 21:31:04 |
connor (he/him) (UTC-7) | IIRC generally lib is preferred because it provides polyfills for functions which aren't available in older versions of Nix and Nixpkgs needs to be able to evaluate with very, very old versions of Nix | 21:37:38 |
10 May 2025 |
| @athyfr:matrix.org left the room. | 12:19:12 |
11 May 2025 |
connor (he/him) (UTC-7) | Alrighty. Things for today:
- fixing Darwin eval since https://github.com/NixOS/nixpkgs/pull/405707 broke it (see my last comment for the fix)
- finishing up PR description for https://github.com/NixOS/nixpkgs/pull/405751
- publishing PR which introduces fix for package set leakage
- publishing PR which introduces pkgsCuda
- publishing PR which moves top-level/cuda-packages.nix to top-level/cuda-overlay.nix, allowing us to maintain CUDA package sets and top level CUDA attributes apart from top-level/all-packages.nix
| 14:18:46 |
connor (he/him) (UTC-7) | Fix for darwin eval here: https://github.com/NixOS/nixpkgs/pull/406207 | 16:23:12 |
12 May 2025 |
connor (he/him) (UTC-7) | SomeoneSerge (UTC+U[-12,12]): sorry for the late reply -- would you mind taking a look at https://github.com/NixOS/nixpkgs/pull/406207? I prefer the current iteration to the alternative you proposed | 00:02:32 |
SomeoneSerge (Ever OOMed by Element) | Been afraid to open Element on my laptop, it keeps causing OMs... | 16:12:35 |
connor (he/him) (UTC-7) | Does the web client cause the same issue? | 16:26:11 |
connor (he/him) (UTC-7) | Split the cudaLib changes into its own PR since the title and previous branch name were misleading: https://github.com/NixOS/nixpkgs/pull/406531 | 18:35:18 |
connor (he/him) (UTC-7) | Haven't verified it yet, but am working on it. I'll make a PR based on it with the cudaFlags -> flags changes as well. | 18:35:46 |
connor (he/him) (UTC-7) | Okay, that PR should be good now. | 19:46:36 |
connor (he/him) (UTC-7) | Serge, here's the cudaFlags -> flags PR I promised: https://github.com/NixOS/nixpkgs/pull/406545 | 19:46:47 |
connor (he/him) (UTC-7) | Building on top of https://github.com/NixOS/nixpkgs/pull/406531, I've drafted https://github.com/NixOS/nixpkgs/pull/406568 (which has docs!) | 21:12:56 |
connor (he/him) (UTC-7) | Would anyone mind looking at/merging this hotfix once CI is green? https://github.com/NixOS/nixpkgs/pull/406575 | 21:23:00 |
Gaétan Lepage | Approved! | 21:23:28 |
13 May 2025 |
SomeoneSerge (Ever OOMed by Element) | In reply to @connorbaker:matrix.org Does the web client cause the same issue? Didn't get to try yet, it's probably a self hosting rabbit hole | 09:11:44 |
connor (he/him) (UTC-7) | I thought generally humanity was trying to get to a state of post-ownership | 13:49:41 |
connor (he/him) (UTC-7) | (i.e. everything as a subscription) | 13:49:54 |
connor (he/him) (UTC-7) | nya hahaha | 13:50:06 |
connor (he/him) (UTC-7) | (sorry it's early my time) | 13:50:11 |
14 May 2025 |
connor (he/him) (UTC-7) | I got through some of your comments on https://github.com/NixOS/nixpkgs/pull/406531 Serge but gotta sleep now
I don't know how much time I'll have today to get through the TODO items I added at the top and in https://github.com/NixOS/nixpkgs/pull/406568, but I am working on it!!! | 08:14:40 |
connor (he/him) (UTC-7) | I also still owe you a review of https://github.com/NixOS/nixpkgs/pull/406740! | 08:15:09 |