7 May 2025 |
SomeoneSerge (Ever OOMed by Element) | connor (he/him) (UTC-7): your shims are basically fixups for manifests aren't they? | 20:03:39 |
connor (he/him) (UTC-7) | Yep! | 20:04:17 |
SomeoneSerge (Ever OOMed by Element) | Now I want (aside from the stuff already listed in TODO): snapshots of nixpkgs attribute trees AND snapshots of callable arguments' functionArgs | 20:42:24 |
connor (he/him) (UTC-7) | There's a builtin for functionArgs which is probably a little more in-depth than the __functionArgs I used: https://github.com/NixOS/nix/blob/1e822bd4149a8bce1da81ee2ad9404986b07914c/src/libexpr/primops.cc#L3135 | 20:47:12 |
SomeoneSerge (Ever OOMed by Element) | There's lib.functionArgs too | 20:48:11 |
| kaya changed their profile picture. | 21:21:02 |
| Tristan Ross joined the room. | 21:46:04 |
Tristan Ross | I have joined here because I may do CUDA stuff with my Ampere Altra Max M128-26 and RTX 5070. | 21:46:43 |
hacker1024 | Ooh is that SBSA then? Good luck lol | 21:47:47 |
Tristan Ross | In reply to @hacker1024:matrix.org Ooh is that SBSA then? Good luck lol Yep, SBSA and ACPI | 21:49:07 |
SomeoneSerge (Ever OOMed by Element) | Isn't this going to be like literally the first time anybody actually uses sbsa version of cuda in Nixpkgs? | 21:49:09 |
Tristan Ross | In reply to @ss:someonex.net Isn't this going to be like literally the first time anybody actually uses sbsa version of cuda in Nixpkgs? Maybe | 21:49:28 |
Tristan Ross | I built a bunch of CUDA stuff that @[connor (he/him) (UTC-7)] has on Saturday | 21:50:07 |
Tristan Ross | There's a lot of things broken lol. | 21:50:17 |
connor (he/him) (UTC-7) | FWIW, I was able to build and train an MLP mixer model this weekend on a GH200 through Lambda Labs using my repo, so proper support is at least in progress lol | 22:04:12 |
SomeoneSerge (Ever OOMed by Element) | Oh riiight we had multiple cudnn s in each package sets and applying fixups to all of them 😅 | 22:25:08 |
connor (he/him) (UTC-7) | Oh god right | 22:32:51 |
SomeoneSerge (Ever OOMed by Element) | Couple days to the feature freeze, perfect time to remove some public attributes | 22:33:42 |
connor (he/him) (UTC-7) | Welp, time to figure out how I managed to break the multiplexing builder | 22:34:16 |
connor (he/him) (UTC-7) | derp | 22:40:42 |
connor (he/him) (UTC-7) | diff --git a/pkgs/top-level/cuda-packages.nix b/pkgs/top-level/cuda-packages.nix
index fc4beb3cea0d..a4a8086c7bf1 100644
--- a/pkgs/top-level/cuda-packages.nix
+++ b/pkgs/top-level/cuda-packages.nix
@@ -40,7 +40,7 @@ let
# Utilities
mkVersionedPackageName =
- name: version: "name_${lib.replaceStrings [ "." ] [ "_" ] (lib.versions.majorMinor version)}";
+ name: version: name + "_" + lib.replaceStrings [ "." ] [ "_" ] (lib.versions.majorMinor version);
in
{
config,
| 22:40:45 |
connor (he/him) (UTC-7) | SomeoneSerge (UTC+U[-12,12]): you okay with me merging https://github.com/NixOS/nixpkgs/pull/405031? | 22:51:56 |
SomeoneSerge (Ever OOMed by Element) | Si por favor | 22:57:06 |
SomeoneSerge (Ever OOMed by Element) | connor (he/him) (UTC-7): do you think we're creating more confusion by renaming fixups? | 23:04:29 |
connor (he/him) (UTC-7) | I like(d) the name fixups because it's distinct from "override" (and all the connotations that carries); I wanted something that gets at the fact the generic builder will get you most of the way to a working package, and that these functions provide the fixes required to go all the way. | 23:07:09 |
connor (he/him) (UTC-7) | Since callPackage is the thing adding .override , I also wanted to steer clear of calling them that because they're supplied to .overrideAttrs and not .override . | 23:07:59 |