| 2 Nov 2025 |
| felix joined the room. | 14:30:39 |
connor (burnt/out) (UTC-8) | Gaétan Lepageis https://github.com/NixOS/nixpkgs/pull/457803 ready to merge? I’ll approve and merge if so | 15:15:24 |
Gaétan Lepage | It fixes the leak for nccl, but firefox gets gcc-wrapper from onnxruntime too. | 16:42:16 |
Gaétan Lepage | I'm about to push a commit that handles that too. I'm compiling rn. | 16:42:28 |
Gaétan Lepage | Rebuilt onnxruntime. It now doesn't depend on cuda_nvcc at runtime.
I'm now rebuilding firefox which should not have cuda_nvcc in its closure anymore. | 17:07:36 |
Gaétan Lepage | 😭 cudaPackages.cuda_cudart depends on cudaPackages.cuda_nvcc at runtime too!!!
Not because of a path leak in the binary this time, just because nvcc is in cudart's propagatedBuildInputs (I think?)
❯ nix why-depends --precise $(nom-build --arg config '{ allowUnfree = true; cudaSupport = true; }' -A firefox-unwrapped) $(nom-build --arg config '{ allowUnfree = true; cudaSupport = true; }' -A cudaPackages.cuda_nvcc)
Finished at 18:16:53 after 1s
Finished at 18:16:53 after 0s
/nix/store/yy1z5y3iql9r4kpslxnjdwcygx52ssl8-firefox-unwrapped-144.0.2
└───lib/firefox/libonnxruntime.so: …st be specified....../nix/store/jk4a7v44fc83ykc15b31r4m21yqc92sp-onnxruntime-1.22.2/lib/.....onn…
→ /nix/store/jk4a7v44fc83ykc15b31r4m21yqc92sp-onnxruntime-1.22.2
└───lib/libonnxruntime_providers_cuda.so: …nn-9.13.0.50-lib/lib:/nix/store/80x699lyc99dahf85iqdv6z1f0vv6vz2-cuda12.8-cuda_cudart-12.8.90/li…
→ /nix/store/80x699lyc99dahf85iqdv6z1f0vv6vz2-cuda12.8-cuda_cudart-12.8.90
└───nix-support/propagated-build-inputs: …fhjm-setup-cuda-hook /nix/store/ygd3s9zm1pf77n3q3ac63v58www5scbc-cuda12.8-cuda_nvcc-12.8.93 /nix…
→ /nix/store/ygd3s9zm1pf77n3q3ac63v58www5scbc-cuda12.8-cuda_nvcc-12.8.93
| 18:19:31 |
Gaétan Lepage | Actually, rebasing my PR on top of [SomeoneSerge (back on matrix)'s](https://github.com/NixOS/nixpkgs/pull/457424) worked! | 20:15:56 |
Gaétan Lepage | * Actually, rebasing my PR on top of Serge's worked! | 20:16:12 |
| 3 Nov 2025 |
connor (burnt/out) (UTC-8) | Are they good to go or do they need more testing? | 00:25:39 |
Gaétan Lepage | According to me, they are both good to go.
Let's wait for SomeoneSerge (back on matrix)'s ACK just to be sure. | 00:26:12 |
connor (burnt/out) (UTC-8) | Thank you both for working on that | 00:26:26 |
Gaétan Lepage | But I confirm that firefox builds fine (no gcc-wrapper triggering disallowedRequisited) with both PRs applied. | 00:26:58 |
Daniel Fahey | CUDA refactor victim fix https://github.com/NixOS/nixpkgs/pull/457870 ready to merge | 13:09:11 |
| Collin Arnett changed their profile picture. | 15:23:43 |
| 4 Aug 2022 |
| Winter (she/her) joined the room. | 03:26:42 |
Winter (she/her) | (hi, just came here to read + respond to this.) | 03:28:52 |
tpw_rules | hey. i had previously sympathzied with samuela and like i said before had some of the same frustrations. i just edited my github comment to add "[CUDA] packages are universally complicated, fragile to package, and critical to daily operations. Nix being able to manage them is unbelievably helpful to those of us who work with them regularly, even if support is downgraded to only having an expectation of function on stable branches." | 03:29:14 |
Winter (she/her) | In reply to @tpw_rules:matrix.org i'm mildly peeved about a recent merging of something i maintain where i'm pretty sure the merger does not own the expensive hardware required to properly test the package. i don't think it broke anything but i was given precisely 45 minutes to see the notification before somebody merged it ugh, 45 minutes? that's... not great. not to air dirty laundry but did you do what samuela did in the wandb PR and at least say that that wasn't a great thing to do? (not sure how else to word that, you get what i mean) | 03:30:23 |
tpw_rules | no, i haven't yet, but i probably will | 03:31:03 |
Winter (she/her) | i admittedly did that with a PR once, i forget how long the maintainer was requested for but i merged it because multiple people reported it fixed the issue. the maintainer said "hey, don't do that" after and now i do think twice before merging. so it could help, is what i'm saying. | 03:31:50 |
tpw_rules | i'm not sure what went wrong with the wandb PR anyway, i think it was just a boneheaded move on the maintainer's part | 03:32:10 |
Winter (she/her) | (it was also simple enough that it was fine and the maintainer said it looked good after) | 03:32:15 |
tpw_rules | * i'm not sure what went wrong with the wandb PR anyway, i think it was just a boneheaded move on the merger's part | 03:32:19 |
tpw_rules | but i thought most of the frustration was around packages which don't really involve CUDA breaking the fragile CUDA packages, and i'm not sure how the warning helps in this case. it's not like nixpkgs-review prints out the comments. maybe i'm wrong. but it is a legitimate problem | 03:34:19 |
Winter (she/her) | the frustration that i see is that people are touching packages that he maintains, am i missing further context here? | 03:35:09 |
tpw_rules | did you ever see this? https://discourse.nixos.org/t/nixpkgss-current-development-workflow-is-not-sustainable/18741 | 03:35:43 |
Winter (she/her) | oh yes i did | 03:35:49 |
Winter (she/her) | but that's not what the topic of this PR/the notice is, though? | 03:36:11 |
Winter (she/her) | this wouldn't help that | 03:36:14 |
Winter (she/her) | ~~is that what you're saying and i'm just lagging behind~~ | 03:36:27 |