| 12 Mar 2025 |
 ruro | * Yes. I also noticed this and so I actually flipped the order (and changed the // to lib.recursiveUpdate) when I implemented the filtering logic, but this change got thrown out with it. | 01:18:29 |
| ruro | * Yes. I also noticed this and so I actually flipped the order (and changed the // to lib.recursiveUpdate) when I originally implemented the filtering logic, but this change got thrown out with it. | 01:18:44 |
 SomeoneSerge (matrix works sometimes) | No I meant its counterpart in release-cuda.nix, the attrset with ... = linux definitions | 01:18:55 |
| SomeoneSerge (matrix works sometimes) |
(and changed the // to lib.recursiveUpdate)
Just in case, this doesn't merge lists
| 01:19:38 |
| ruro | Yeah. Then I think that it makes sense not to filter them out automatically. If someone explicitly added somepackage = linux; then I think that we should have an eval error if somepackage doesn't support linux. | 01:20:14 |
| SomeoneSerge (matrix works sometimes) | Yes that was the intent | 01:20:37 |
| ruro | Yes. That was the intended effect. | 01:20:38 |
| ruro | So that, for example, someone could do cudaPackages.some_package = [ ]; or something. | 01:21:27 |
| ruro | * So that, for example, someone could do cudaPackages.some_package = [ ]; in the "explicit" attrset or something. | 01:21:42 |
| SomeoneSerge (matrix works sometimes) | I see | 01:21:46 |
| ruro | If you want, I can add it back in. But I think that this reordering was one of the reasons for the indentation change that you wanted to avoid))) | 01:23:08 |
| SomeoneSerge (matrix works sometimes) | Well, ok. Let's swap the order. And for the packageSets variable and for evalPackageSet they actually don't seem to be doing anything useful. The packageSets there really only serves the purpose of automatically identifying the cuda package sets, so let's rename it to cudaPackageSets as, I think, you've already suggested. Let's not introduce the extra variable for evalPackageSet nor for its image, but instead just use packagePlatforms directly in jobs = let in HERE // { ... = linuxl } | 01:24:30 |
| SomeoneSerge (matrix works sometimes) | * Well, ok. Let's swap the order. And for the packageSets variable and for evalPackageSet they actually don't seem to be doing anything useful. The packageSets there really only serves the purpose of automatically identifying the cuda package sets, so let's rename it to cudaPackageSets as, I think, you've already suggested. Let's not introduce the extra variable for evalPackageSet nor for its image, but instead just use packagePlatforms directly in jobs = let in HERE // { ... = linuxl } | 01:24:37 |
| SomeoneSerge (matrix works sometimes) | * Well, ok. Let's swap the order. And for the packageSets variable and for evalPackageSet they actually don't seem to be doing anything useful. The packageSets there really only serves the purpose of automatically identifying the cuda package sets, so let's rename it to cudaPackageSets as, I think, you've already suggested. Let's not introduce the extra variable for evalPackageSet nor for its image, but instead just use packagePlatforms directly in jobs = let in HERE // { ... = linux; } | 01:24:42 |
| SomeoneSerge (matrix works sometimes) | wdyt? | 01:24:45 |
