| 31 Aug 2022 |
 tpw_rules | 
Download image.png | 20:00:02 |
 hexa (UTC+1) | tpw_rules: for both src and bin? | 21:33:12 |
| hexa (UTC+1) | wait, the wheel doesn't consume it 😄 | 21:35:15 |
| tpw_rules | no i just tried src | 21:45:49 |
| tpw_rules | "consume"? | 21:46:00 |
| hexa (UTC+1) | it does not have cudaPackages in its argument list | 21:48:18 |
| tpw_rules | it looks like it still includes cuda. let me see what happens... | 21:50:58 |
| hexa (UTC+1) | the bin.nix doesn't mention cuda except in comments | 21:53:45 |
| tpw_rules | yeah ima try if i can get it to do cuda type things | 21:54:02 |
| tpw_rules | it should be much faster than building though | 21:54:11 |
| tpw_rules | yeah it does do cuda things | 21:56:01 |
| tpw_rules | and the wheel has all the cuda .so files | 21:56:24 |
| hexa (UTC+1) | ok, great | 22:03:05 |
| hexa (UTC+1) | so the cuda arch support list remains todo? | 22:03:33 |
| tpw_rules | oh, no, i did check that and it doesn't need to be expanded | 22:03:56 |
| tpw_rules | there is a new 8.7 architecture but that's only for the nvidia agx embedded aarch64 things which nixpkgs doesn't touch yet | 22:04:22 |
| tpw_rules | from my perspective it's ready for merging. samuela says we shouldn't have that cuda packages pin, and it's immaterial now | 22:05:53 |
| tpw_rules | but i think you rebased when you force pushed so the diff is meaningless to me | 22:06:07 |
| hexa (UTC+1) | yes, rebased onto a recent master | 22:06:37 |
| tpw_rules | what did you change when you force pushed? | 22:06:50 |
| hexa (UTC+1) | https://github.com/NixOS/nixpkgs/pull/189013#pullrequestreview-1092543709 | 22:07:01 |
| hexa (UTC+1) | just this | 22:07:04 |
| tpw_rules | just added that line? meh if you added it then whatever. samuela says the "usual practice" is to not have it. but it doesn't actually change anything at this point because we haven't packaged cuda 11.7 yet | 22:08:01 |
| hexa (UTC+1) | I can drop it, I don't mind | 22:10:08 |
| tpw_rules | ok. i'd say drop that line then merge | 22:10:49 |
| hexa (UTC+1) | sgtm | 22:10:54 |
| tpw_rules | do you always rebase onto master as part of force pushing? your diff ended up with a bunch of random junk in it again | 22:23:00 |
| hexa (UTC+1) | huh | 22:48:51 |
| hexa (UTC+1) | yeah, mostly. | 22:49:00 |
| hexa (UTC+1) | the diff should be the same against master | 22:49:09 |
