| 9 May 2022 |
 Pol | Merged !! ^^ | 16:27:14 |
| Pol | Jan Tojnar: What is this issue? https://github.com/fossar/nix-phps/runs/6357683823?check_suite_focus=true Where does it comes from ?! | 19:20:00 |
 Jan Tojnar | Pol: that is phpize not setting the RE2C or BISON make variables | 19:21:21 |
| Jan Tojnar | * Pol: that is phpize-generated configure script not setting the RE2C or BISON make variables | 19:21:44 |
| Pol | arghf**k | 19:21:56 |
| Pol | Is it a new patch to do for nix-phps or nixpkgs ? | 19:22:14 |
| Jan Tojnar | as explained here https://github.com/fossar/nix-phps/pull/104#issuecomment-1113964195 | 19:22:42 |
| Pol | Aaaah I do remember now. | 19:23:06 |
| Jan Tojnar | technically, Nixpkgs is affected too, only they do not notice because the tarballs already contain the generated files | 19:23:46 |
| Pol | Maybe we should fix it in nixpkgs directly | 19:24:07 |
| Pol | WDYT ? | 19:24:31 |
| Jan Tojnar | yeah, probably test here first and then move the fix to Nixpkgs like we did with the readline issue | 19:25:31 |
| Pol | Right, so the battleplan is to add those variables and that's it? | 19:26:19 |
| Jan Tojnar | Adding directly them using makeFlags would work as a workaround. But ideally we would instead add https://github.com/php/php-src/blob/9e74e58bcf7e31aef563f1ee00b7f0bc17fe3ef2/configure.ac#L164-L165 to the generated configure.ac. | 19:29:34 |
| Jan Tojnar | Maybe just adding those lines at the top of config.m4 would work? | 19:30:28 |
| Pol | I don't know... I like the idea of using makeFlags. | 19:31:19 |
| Pol | 
Download image.png | 19:31:38 |
| Pol | Is it here that we have to add it ? | 19:31:39 |
| Jan Tojnar | no, it should go to the package-overrides | 19:32:01 |
| Pol | ah ok ! | 19:32:06 |
| Jan Tojnar | the issue with makeFlags is that you have to replicate whatever the m4 macros do | 19:33:22 |
| Pol | 
Download image.png | 19:33:42 |
| Jan Tojnar | finding yacc itself will be easy but what should you set YFLAGS to? And what if upstream changes it? | 19:34:27 |
| Pol | ha. | 19:34:35 |
| Pol | indeed. | 19:34:45 |
| Jan Tojnar | yeah, that looks about right to me, though please follow https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-ordering.md | 19:34:51 |
| Pol | In reply to @jtojnar:matrix.org
finding yacc itself will be easy but what should you set YFLAGS to? And what if upstream changes it? Maybe adding it on the top of the file might be a better fit | 19:36:53 |
| Pol | Damn, let me know what we do :) | 19:39:02 |
| Jan Tojnar | Pol: if you could try pasting those lines to the top of ext/pdo/config.m4 in postPatch that would be a start | 19:45:44 |
| Pol | Right, going to experiment ;) | 19:46:00 |
