| 9 Nov 2022 |
 etu | Somehow we have lost the maintainers arrays from phpPackages packages | 14:37:48 |
| etu | ~/code/nixpkgs $ nix repl .
nix-repl> :p php.packages.composer.meta
{ available = true; broken = false; insecure = false; mainProgram = "composer"; name = "php-composer-2.4.4"; outputsToInstall = [ "out" ]; position = "/home/etu/code/nixpkgs/pkgs/development/php-packages/composer/default.nix:7"; unfree = false; unsupported = false; }
| 14:38:30 |
| etu | However I can see it in the code, so my best guess is that it has something to do with https://github.com/NixOS/nixpkgs/commit/58919907a73f2bd0329f8943875d7bab9c5eca8e | 14:41:26 |
| etu | Yep, I can confirm locally that removing the setting of meta.mainProgram in the mkDerivation definition gets us the maintainers list back. | 14:42:48 |
 Pol | This is maybe the reason why I was not ping anymore | 14:48:01 |
| Pol | There's this PR that I haven't seen: https://github.com/NixOS/nixpkgs/pull/198037 | 14:49:26 |
| etu | Yeah, I RSS the updates regarding packages that I maintain via repology and just got a whole bunch of updates that I stopped receiving updates for all php packages. So I was curious about that 😉 | 14:49:47 |
| Pol | nice finding | 14:50:15 |
 Jan Tojnar | maybe we should just drop the mkDerivation | 18:21:24 |
| Jan Tojnar | I do not really see a point prefixing the package name with php https://github.com/ilkecan/nixpkgs/commit/06e0ede06ec1b2e97637b93e2b00c1eb9c71d3a6 | 18:21:43 |
| 10 Nov 2022 |
| Pol | We need senior review here: https://github.com/NixOS/nixpkgs/pull/198470 | 13:01:35 |
| Pol | It modifies the PHP stuff | 13:01:44 |
| 11 Nov 2022 |
 ma27 | friendly ping re the PR linked above, would be cool to get some more reviewers on that :) | 22:43:16 |
| 12 Nov 2022 |
| Pol | Thanks etu! | 08:01:57 |
| etu | Pol: I was thinking about this NTS/ZTS thing | 10:08:31 |
| Pol | yep | 10:08:39 |
| Pol | me too :) | 10:08:42 |
| etu | Why is it depending on isDarwin? | 10:08:57 |
| etu | Is it because ZTS doesn't work on darwin or something like that? | 10:09:15 |
| Pol | No, zts was mostly used because of mod_php on apache | 10:09:47 |
| etu | Then it's weird that it depends on isDarwin 😛 | 10:10:24 |
| etu | So we would want... NTS by default, right? | 10:19:46 |
| etu | And then maybe a separate attribute name for php with ZTS | 10:19:58 |
| etu | like mod_php80 mod_php81 mod_php or something? And then use that by default for apache. | 10:20:46 |
| Pol | yes | 10:21:45 |
| etu | Pol: You feel up for doing those changes to your draft? | 10:28:42 |
| etu | Pol: And yeah, stop make it depending on isDarwin | 10:28:56 |
| Pol | I can try :) | 10:48:57 |
| Pol | Job done etu ! https://github.com/NixOS/nixpkgs/pull/194172 | 21:57:31 |
| Pol | I like the change | 21:57:37 |
