| 25 Apr 2022 |
 Pol |
- https://github.com/NixOS/nixpkgs/pull/157287
- https://github.com/NixOS/nixpkgs/issues/154774
| 07:54:22 |
| Pol | It would be so nice to push these 2 issues. | 07:54:32 |
| Pol | The first one prevent me to use infection/infection locally. As it needs XDebug, it fails because of all the warnings. | 07:54:58 |
| Pol | The second one also need some care, but I don't know where or how to start. | 07:55:19 |
 etu | Writing a test | 07:55:30 |
| Pol | I don't really know, if you could give it some love or at least explain a bit how to do, I might have a look at some point. | 07:56:21 |
| etu | Here's the tests file for php: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/php/default.nix | 07:58:30 |
| etu | Where we include the tests | 07:58:34 |
| etu | They are then declared for each PHP version in the all tests file: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/all-tests.nix#L420-L423 | 07:59:09 |
| etu | So we run all tests as each version | 07:59:17 |
| etu | So it launches a NixOS VM and sets up services or runs commands and all that, then we can curl the VM to check if things works as expected | 07:59:57 |
| Pol | mmh mmh, thanks, will have a look as soon as I have some time. | 08:01:03 |
| Pol | If you have an idea on how to write the test, please let me know. | 08:01:16 |
| etu | We also have this hack to pass through the "right version" of the tests to each PHP package: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/interpreters/php/generic.nix#L155 | 08:01:49 |
| etu | So you can build php81.tests to eval the tests with php81 | 08:02:19 |
| etu | But this last bit doesn't need any changes, it's just good to know :) | 08:02:40 |
| Pol | Thanks mate | 08:02:57 |
| Pol | I'll ping you for further questions if needed. Don't know when, but I will. | 08:03:17 |
| etu | I think the zts thing should be addressed after the next release branch off | 08:04:24 |
| etu | Just as we should drop php74 and change to php81 as default by then | 08:04:39 |
| Pol | Oki, could you comment on the thread, so this information is not lost in the matrix's void :) | 08:05:03 |
 Andreas Schrägle | In reply to @etu:semi.social
Just as we should drop php74 and change to php81 as default by then You can add that to the 22.11 blockers project | 08:08:10 |
| etu | Oh, great suggestion :) | 08:11:47 |
| etu | Done! | 08:13:30 |
| Pol | How do you do that? | 08:18:15 |
| 26 Apr 2022 |
| Pol | https://dpaste.org/a3euL | 05:23:01 |
| Pol | Looks like the GCC update broke PHP < 7.4 compilation | 05:23:13 |
| Andreas Schrägle | the easiest way around that is probably just using gcc < 11 | 07:22:54 |
| Andreas Schrägle | Also, how does nix-php (is that what it's called) handle openssl_1_0_2 finally not being a thing anymore in nixpkgs? | 07:23:27 |
| Pol | It's using a patch | 08:33:54 |
