| 27 Feb 2024 |
 K900 ⚡️ | I mean | 19:59:43 |
| K900 ⚡️ | If you do create_machine({"startCommand": "..."}) | 19:59:52 |
| K900 ⚡️ | You don't get the warning | 19:59:55 |
| K900 ⚡️ | And you get the right thing done | 20:00:01 |
 Alyssa Ross | Oh, I see. | 20:00:15 |
| K900 ⚡️ | And after my PR you just need to change that to create_machine(start_command="...") now | 20:00:20 |
| Alyssa Ross | That makes more sense —-I thought I'd have seen the warning. | 20:00:26 |
| Alyssa Ross | Right | 20:00:30 |
| K900 ⚡️ | But if you do create_machine({"hda": "foo.qcow2"}) or whatever | 20:00:37 |
| K900 ⚡️ | That would get you the warning | 20:00:44 |
| Alyssa Ross | Right | 20:00:48 |
| K900 ⚡️ | And now it would blow up | 20:00:49 |
| Alyssa Ross | Yeah I agree the non-startCommand keys don't need a deprecation period then. | 20:01:06 |
| Alyssa Ross | The reason to do a deprecation period is usually to make it possible to have some code that works with both stable and unstable. | 20:01:34 |
| K900 ⚡️ | I guess that's true | 20:01:45 |
| K900 ⚡️ | I can add a hack for that | 20:01:48 |
| Alyssa Ross | And then remove it after branch-off. | 20:01:59 |
| Alyssa Ross | Usually we silently add the new API, wait a release, add a warning, wait a release, remove the old one. | 20:02:17 |
| Alyssa Ross | But I don't think that's necessary here because warnings from the test driver are not nearly as disruptive as warnings from Nix. | 20:02:31 |
| Alyssa Ross | So adding a warning straight away should be fine. | 20:02:49 |
| K900 ⚡️ | @Alyssa Ross can you test your stuff against my branch? | 20:15:28 |
| K900 ⚡️ | It should warn now | 20:15:31 |
| K900 ⚡️ | And hopefully catch a whole bunch of stupid cases | 20:15:40 |
| K900 ⚡️ | (thanks mypy) | 20:15:42 |
| Alyssa Ross | can do | 20:17:14 |
| Alyssa Ross | (My stuff is https://spectrum-os.org/git/spectrum/tree/release/checks/try.nix?id=0b84f07c366366e26fa4047bac1c47037450d501 and https://spectrum-os.org/git/spectrum/tree/release/checks/no-roothash.nix?id=0b84f07c366366e26fa4047bac1c47037450d501 btw) | 20:17:51 |
| K900 ⚡️ | Yeah those should definitely work | 20:18:40 |
| 28 Feb 2024 |
| Alyssa Ross | k900: as expected, they do. | 00:21:24 |
| K900 ⚡️ | Cool | 06:13:13 |
| K900 ⚡️ | And does it scream at you | 06:13:23 |
