| 13 Jun 2023 |
 baloo | I'm not too sure I understand how the code is different from the description to be honest. | 18:39:43 |
| baloo | maybe only review the first commit, the second adds noise because it brings a test to cover the issue. | 18:40:08 |
|  @federicodschonborn:matrix.org changed their profile picture. | 20:56:03 |
| 14 Jun 2023 |
 Robert Hensing (roberth) | In reply to @raitobezarius:matrix.org
(directBoot is now merged, diskless VMs might be much simpler thanks to the persistent PR from nikstur, etc, etc.) a rebase would reviewers I think | 10:27:31 |
| Robert Hensing (roberth) | * a rebase would help reviewers I think | 12:12:07 |
| 8 Jul 2023 |
 jonge | hey friends, i created a PR that syncs the docstrings of the Machine class's methods and the nixos docs of the test driver. if anybody would be interested to look at this this would be a great help: https://github.com/NixOS/nixpkgs/pull/242135 | 10:09:27 |
 raitobezarius | Will take a look when I can :-) | 10:53:52 |
| raitobezarius | Thank you! | 10:53:55 |
| 10 Jul 2023 |
|  nikstur joined the room. | 14:29:36 |
| nikstur | Is there any simple way I can wait for a machine to reboot? I want to test a service that automatically reboots the machine on success (as unitConfig.SuccessAction = "reboot"; so the reboot is not initiated by the test itself | 14:31:18 |
| nikstur | I'll even take a complex way because I can't figure it out :D | 14:43:53 |
| raitobezarius | wait_for_unit("$unit.service") ? :p | 14:44:13 |
| raitobezarius | after a machine.crash() ? | 14:44:21 |
| nikstur | Works only if I trigger the crash from within the test. But the service running in the VM triggers the reboot | 15:01:01 |
| raitobezarius | hmm | 15:01:12 |
| raitobezarius | so you want something to say "now you are rebooting" | 15:01:22 |
| nikstur | And waiting for reboot.target etc doesnt work either | 15:01:27 |
| raitobezarius | our protocol to assert the state of the machine is suboptimal for that | 15:01:43 |
| nikstur | wait_for_reboot() or something | 15:01:44 |
| raitobezarius | I think you need to do adjustments for that | 15:01:49 |
| raitobezarius | in the internal state machine | 15:01:53 |
| nikstur | Had hoped, I wouldn't need to touch it | 15:06:43 |
| nikstur | mhhhm | 15:06:49 |
| nikstur | Ok so one thing I figured out is that I need to set machine.connected = False so that it reconnects to the shell | 15:12:23 |
| nikstur | Now I can machine.sleep but thats obv not a very robus solution | 15:12:50 |
| raitobezarius | There was discussion in NixOS Systemd about RIIR the protocol between VM and driver | 15:16:52 |
| raitobezarius | so it would have proper framing, et. | 15:16:56 |
| raitobezarius | * so it would have proper framing, etc. | 15:16:58 |
