!kjdutkOsheZdjqYmqp:nixos.org

Empty Room

1706 Members
364 Servers

Load older messages


SenderMessageTime
14 Jan 2025
@k900:0upti.meK900No, you just run the lint twice11:36:10
@niklaskorz:korz.devNiklas Korzsometimes it's the simple solutions that work best😄11:36:40
@lily:lily.flowers@lily:lily.flowers
In reply to @grimmauld:grimmauld.de
Don't you need to store a count of how many "disallowed" patterns were in the code before a change to determine whether an addition is adding one of those disallowed patterns?
it's ratched per-file and yeah just run before to determine whether it's already ratcheted and if an after lint run needs to be enforced
11:37:45
@grimmauld:grimmauld.deGrimmauld (moving to @grimmauld:grapevine.grimmauld.de)
In reply to @k900:0upti.me
No, you just run the lint twice
Ah fair. Yeah that works. Damn it, no need to be smart I guess XD
11:37:44
@lily:lily.flowers@lily:lily.flowers* it's ratched per-file and yeah just run before to determine whether it's already ratcheted which determines if an after lint run needs to be enforced11:38:06
@lily:lily.flowers@lily:lily.flowers* it's ratched per-file and yeah just run before-change to determine whether it's already ratcheted which determines if an after-change lint run needs to be enforced11:38:22
@infinisil:matrix.org@infinisil:matrix.org

@grimmauld:grimmauld.de https://github.com/NixOS/nixpkgs-vet?tab=readme-ov-file#ratchet-checks

11:40:20
@infinisil:matrix.org@infinisil:matrix.org

And https://github.com/NixOS/nixpkgs-vet/pull/142 would introduce a new one for with

11:41:23
@ceverekomu:matrix.orgceverekomu joined the room.11:53:38
@perchun:matrix.orgPerchun Pak [don't ping; dm instead]funny that I am working on finalAttrs support for buildPython* right now and while I wait for eval results I read this chat not everything can be implemented using hooks, how could you implement something like this? https://github.com/NixOS/nixpkgs/blob/deb4f62a8ad1971753042cdb34138f739110425f/pkgs/development/libraries/astal/buildAstalModule.nix#L40-L7812:10:04
@collares:matrix.orgcollaresIt would be good to have data on whether finalAttrs is responsible for the huge increase in nixpkgs-review eval time over the last year12:24:05
@collares:matrix.orgcollaresThis whole finalAttrs thing really should have been an RFC, given the multiple perf concerns in #119942. But I think people were getting impatient.13:13:04
@collares:matrix.orgcollares(and I don't remember if there was a good RFC system at the time)13:14:03
@emilazy:matrix.orgemilythere was the same bad RFC system that exists now14:49:00
@amadaluzia:tchncs.de@amadaluzia:tchncs.dehas anyone ever bothered packaging the xontribs as of yet?14:53:27
@amadaluzia:tchncs.de@amadaluzia:tchncs.defor non-xonsh users: a xontrib is an extension for xonsh14:54:00
@amadaluzia:tchncs.de@amadaluzia:tchncs.dethey are basically just python packages but weird14:54:23
@amadaluzia:tchncs.de@amadaluzia:tchncs.de

they use their own xsh format which is python but with xonsh's magic hand

14:54:47
@amadaluzia:tchncs.de@amadaluzia:tchncs.dehttps://github.com/74th/xonsh-direnv14:55:11
@amadaluzia:tchncs.de@amadaluzia:tchncs.dean example xonsh is this14:55:15
@amadaluzia:tchncs.de@amadaluzia:tchncs.de * 14:55:39
@hexa:lossy.networkhexahas a setup.py, how weird can it be?14:55:49
@hexa:lossy.networkhexathey probably abuse pypi as a distribution point14:56:17
@amadaluzia:tchncs.de@amadaluzia:tchncs.deit hasn't treated xonsh users badly14:56:29
@amadaluzia:tchncs.de@amadaluzia:tchncs.dei know someone who uses xonsh with nix and they have a crazy extraPackages override14:56:51
@emilazy:matrix.orgemilyxonsh packaging is already very weird in Nixpkgs I think14:56:57
@emilazy:matrix.orgemily because of PYTHONPATH madness 14:57:01
@amadaluzia:tchncs.de@amadaluzia:tchncs.de * 14:57:18
@amadaluzia:tchncs.de@amadaluzia:tchncs.dewhat am i looking at lol14:58:19
@amadaluzia:tchncs.de@amadaluzia:tchncs.denever seen someone let the entire derivation then use it14:58:44

Show newer messages


Back to Room ListRoom Version: 6