21 Oct 2024 |
Alyssa Ross | Yeah | 12:25:01 |
Alyssa Ross | Lots of those checks are actually just checking whether it's a cross compile | 12:25:19 |
Alyssa Ross | Which will always be true for these new packages | 12:25:25 |
Alyssa Ross | AVR patch should also be unconditionally appliable | 12:27:03 |
Alyssa Ross | The optional dependencies for specific platforms look highly sus | 12:27:36 |
Alyssa Ross | It looks like autoreconfHook was added at the same time as the patch for iOS, but the patch doesn't look like it should need an autoreconf? | 12:29:16 |
Alyssa Ross | oh I do not like that vc4 is using some fork | 12:30:18 |
Alyssa Ross | which has been abandoned for 12 years | 12:31:04 |
Alyssa Ross | emilyyou removed a default-gcc-version override for vc4 recently. Do you know if anybody is still using it?
| 12:31:53 |
Alyssa Ross | Oh apparently nobody is, because the patches don't even apply to it lol | 12:32:19 |
Alyssa Ross | So I think we can just remove the vc4 stuff, given it hasn't built in forever anyway | 12:32:33 |
Alyssa Ross | Tethys Svenssonwould you like me to try cleaning binutils up a bit before we add the extra ones, so we can get rid of (most of) the targetPlatform checks?
| 12:33:08 |
Tethys Svensson | Yes, that would be amazing. Please do! ⭐️ | 12:33:34 |
Alyssa Ross | I'll see what I can do | 12:33:55 |
Alyssa Ross | Okay the iOS patch does not apply, which implies nobody cares about that either, assuming that's been the case for a while | 12:36:25 |
Alyssa Ross | (yay conditional patches) | 12:36:42 |
emily | In reply to @qyliss:fairydust.space
emilyyou removed a default-gcc-version override for vc4 recently. Do you know if anybody is still using it?
I think that was me merging someone else's PR and it looked extremely like it wasn't still working | 12:39:31 |
Alyssa Ross | ah yes maybe | 12:39:39 |
Alyssa Ross | the new merges still confuse me | 12:39:54 |
emily | I think some of it got removed already? iirc @cleverca22:matrix.org used it for FOSS raspi firmware or something
| 12:40:00 |
| @ners:nixos.dev left the room. | 13:08:51 |
Artturin | In reply to @qyliss:fairydust.space
emilyyou removed a default-gcc-version override for vc4 recently. Do you know if anybody is still using it?
I did
pkgsCross.vc4.stdenv.cc is broken in the patching of binutils
| 13:38:12 |
Artturin | * I did remove it
pkgsCross.vc4.stdenv.cc is broken in the patching of binutils
| 13:38:40 |
Alyssa Ross | Yeah, that's what I'm running into now | 13:38:43 |
Alyssa Ross | Checking whether it's been broken a long time. If it has I think we can just remove it. | 13:38:54 |
Artturin | Found one use https://github.com/librerpi/lk-overlay/blob/2ef5122065892860bdb5035d331be8494deb58e2/default.nix#L29 And that's by cleverca22: who added vc4 support https://github.com/NixOS/nixpkgs/pull/72657 | 13:45:38 |
emily | yeah and it's pinned to a commit from 2019 | 13:46:19 |
emily | so… kill it | 13:46:34 |
pveierland | Huh, neat. Nixpkgs has over 1M commits now (1 030 167 just counted) | 13:57:49 |
Alyssa Ross | It turns out that until https://github.com/nixos/nixpkgs/commit/7f1bc0d5c1d0d669990cd59c2c8cf5a8b58e8cf2 the vc4 src override was accidentally not being used anyway lol | 14:00:37 |