| 20 Oct 2024 |
 emily | https://github.com/NixOS/nixpkgs/pull/332412 was the previous PR with some discussion | 03:49:08 |
| emily | given the august 7 and august 8 merge dates i wouldn't be surprised if the old version never even reached a channel | 03:49:26 |
 SigmaSquadron | crisis averted then? | 03:49:45 |
| emily | i do not personally see any issue currently at least | 03:50:38 |
 Artturin | In reply to @robert:funklause.de
Oh you're right Maybe edit the messages in other channels to be a bit milder since there weren't really any major violations, just some missing motives 😅 | 03:50:39 |
| emily | it's important that we have people check work against our standards but when criticizing people for sloppiness it's especially important to make sure we don't make mistakes from oversights ourselves in the process. could use a little less shoot-first-ask-questions-later | 03:56:28 |
 Tomodachi94 | Does anyone know if stuebinm's nixq has any documentation? Investigating it to see if it can help me semi-automatically do a treewide change (replacing qt5.mkDerivation with stdenv.mkDerivation in most cases). | 04:39:03 |
| Tomodachi94 | Does anyone know if stuebinm's nixq has any documentation? Investigating it to see if it can help me semi-automatically do a treewide change (replacing qt5.mkDerivation with stdenv.mkDerivation in most cases and adding qt5.wrapQt5Apps). | 04:40:51 |
| Tomodachi94 | cc @stue:matrix.org, who might be stuebinm? | 04:45:08 |
| emily | previous discussion fwiw https://matrix.to/#/!kjdutkOsheZdjqYmqp:nixos.org/$BNb-xIiQz6tsVHvZZAAMmVkBV0lGCXig0Ovmoqqf-Rc?via=nixos.org&via=matrix.org&via=nixos.dev | 04:46:46 |
| emily | I would like to write a general-purpose Nix refactoring framework | 04:48:34 |
| emily | I do not think anything exists currently that can reliably achieve the kind of thing you are going for | 04:48:45 |
| emily | but I would like one to exist | 04:49:11 |
| emily | my understanding is that most uses of Qt 5 in Nixpkgs might not have that long to live anyway though. you may wish to coordinate with K900 | 04:49:42 |
| Tomodachi94 | I have an idea that involves basically chaining a bunch of sed invocations and also accounts for the preexisting formatting at the same time (shudder), but that falls apart when I need to insert something | 04:50:51 |
| Tomodachi94 | I had an idea that involves basically chaining a bunch of sed invocations and also accounts for the preexisting formatting at the same time (shudder), but that falls apart when I need to insert something | 04:50:58 |
| Tomodachi94 | In reply to@emilazy:matrix.org
my understanding is that most uses of Qt 5 in Nixpkgs might not have that long to live anyway though. you may wish to coordinate with K900 See also, the tracking issue for this: https://github.com/NixOS/nixpkgs/issues/180841 | 04:52:20 |
| emily | In reply to @tomodachi94:matrix.org
I had an idea that involves basically chaining a bunch of sed invocations and also accounts for the preexisting formatting at the same time (shudder), but that falls apart when I need to insert something if you can rely on nixfmt then you can do horrible things like replace nativeBuildInputs = [ | 04:52:55 |
| emily | but yes, not being able to think of a good way to do a build inputs-affecting refactor for macOS stuff is why I started planning a proper framework | 04:53:20 |
| Tomodachi94 | In reply to@emilazy:matrix.org
if you can rely on nixfmt then you can do horrible things like replace nativeBuildInputs = [ Yep, Another tricky thing that nixfmt might have fixed would be removing the "import" of qt5.mkDerivation when it uses qt5.callPackage (the format is wildly inconsistent) | 04:54:27 |
| Tomodachi94 | I had an idea that involves basically chaining a bunch of sed invocations that also account for the preexisting formatting at the same time (shudder), but that falls apart when I need to insert something | 04:54:48 |
| emily | I think it would be okay to nixfmt files before touching them | 04:54:59 |
| emily | going by ripgrep results, we're talking about some ~40 packages? | 04:56:06 |
| emily | I think you're best off just doing it manually | 04:56:10 |
| Tomodachi94 | I do have a script that lists most of the problematic files (afaik) | 04:56:11 |
| Tomodachi94 | In reply to@emilazy:matrix.org
going by ripgrep results, we're talking about some ~40 packages? Closer to 600, qt5.callPackage obscures them | 04:56:28 |
| emily | i was grepping for qt5.callPackage, i guess i did it wrong | 04:56:39 |
| Tomodachi94 | In reply to@emilazy:matrix.org
i was grepping for qt5.callPackage, i guess i did it wrong I also did something similar initially 🙈 https://github.com/NixOS/nixpkgs/issues/180841#issuecomment-2423659515 | 04:57:36 |
| emily | oh, because libsForQt5. | 04:57:53 |
| emily | I believe that the Plasma 5 parts of those will go away at some point according to K900's intention | 04:58:15 |
