21 Oct 2024 |
SigmaSquadron | huh, in my experience OfBorg takes like an hour max to evaluate, maybe 5-6 to build and check | 17:00:14 |
Lily Foster | In reply to @sigmasquadron:matrix.org huh, in my experience OfBorg takes like an hour max to evaluate, maybe 5-6 to build and check yeah but the queue depth is like 100 PRs waiting and eval takes like 15 minutes with 15 evaluators currently | 17:33:24 |
Lily Foster | so it's gonna be longer than an hour | 17:33:32 |
Lily Foster | (hopefully not too much longer though) | 17:33:50 |
Lily Foster | * yeah but the queue depth is like 100 PRs waiting and eval takes like 15 minutes with 15 evaluators currently working through the queue | 17:35:34 |
Lily Foster | * (hopefully not too much longer than that though) | 17:35:40 |
jh-devv 🏳️⚧️ | Download image.png | 17:44:05 |
jh-devv 🏳️⚧️ | This is in the docker docs for config.Env
| 17:44:25 |
jh-devv 🏳️⚧️ | How do I type this in nix? | 17:44:55 |
jh-devv 🏳️⚧️ | For pkgs.dockerTools.buildImage.config.Env
| 17:45:32 |
jh-devv 🏳️⚧️ | * For pkgs.dockerTools.buildImage.config
| 17:45:45 |
jh-devv 🏳️⚧️ | https://github.com/moby/moby/blob/46f7ab808b9504d735d600e259ca0723f76fb164/image/spec/spec.md#image-json-field-descriptions | 17:47:10 |
jh-devv 🏳️⚧️ | https://nixos.org/manual/nixpkgs/stable/#ex-dockerTools-buildImage-config | 17:47:31 |
jh-devv 🏳️⚧️ | > /nix/store/3jnyh9rpp00b3y4mkl4xrpvppqj7yca7-stdenv-linux/setup: eval: line 1815: unexpected EOF while looking for matching `"'
| 17:52:31 |
jh-devv 🏳️⚧️ | oh | 17:58:02 |
jh-devv 🏳️⚧️ | found the issue | 17:58:05 |
jh-devv 🏳️⚧️ | lol | 17:58:06 |
Tethys Svensson | Alyssa Ross: Are you planning on doing more cleanup to binutils or are you done for now? :) | 18:04:07 |
Alyssa Ross | I'm opening a PR as we speak :) | 18:07:27 |
Alyssa Ross | I had to wait for the periodic merge action, because this one has to go to staging. | 18:07:38 |
Alyssa Ross | but it just finished | 18:07:56 |
| diniamo joined the room. | 18:09:28 |
Alyssa Ross | I don't think there's much more to do after this. If we were doing full binutils packages for other platforms, I'd pull enableGold's default value out into all-packages.nix so it didn't affect those packages, but I'd still prefer to only have gas packages if possible, so I'm holding off on that for now. | 18:10:36 |
Tethys Svensson | Alyssa Ross: I think I can do a nixpkgs specific patch for pwntools to make it use binutils-unwrapped-all-targets for everything except gas. I don't think an upstream patch is going to more work than I'm able to commit to at this time. | 18:11:51 |
Tethys Svensson | I wouldn't know how to make a gas-only build either. | 18:12:43 |
Alyssa Ross | My guess is that we just need to set sourceRoot to gas | 18:12:58 |
Alyssa Ross | But I can check | 18:13:01 |
Tethys Svensson | * Alyssa Ross: I think I can do a nixpkgs specific patch for pwntools to make it use binutils-unwrapped-all-targets for everything except gas. I think an upstream patch is going to more work than I'm able to commit to at this time. | 18:13:04 |
Alyssa Ross | In reply to @luckytethys:matrix.org Alyssa Ross: I think I can do a nixpkgs specific patch for pwntools to make it use binutils-unwrapped-all-targets for everything except gas. I think an upstream patch is going to more work than I'm able to commit to at this time. I'd be happy with this, but the pwntools package maintainers will need to be too. | 18:14:36 |
Tethys Svensson | I'm pretty sure at least 1 out of 3 of the pwntools maintainers (kristoff3r) would be happy to accept that. I don't know the other maintainers. | 18:15:56 |