| 20 Oct 2024 |
 Tomodachi94 | * Especially breaking changes on stable branches 🫡 /j | 03:16:15 |
 dotlambda | In reply to @sigmasquadron:matrix.org
yep, that does fall on the category of 'pretty bad'.
But maybe it's best to discuss this with Pol before anything? I pinged them in a different Matrix room, they are not in this one. | 03:16:21 |
 Artturin | @robert:funklause.de: you may want to ping pol with the link to this room | 03:25:53 |
| Artturin | * @robert:funklause.de: you may want to ping pol with the link to this room instead | 03:26:07 |
| Artturin | In reply to @robert:funklause.de
https://github.com/NixOS/nixpkgs/pull/332915 It kinda looks like most of the commits without open-webui inn hem are package updated to packages which are new to that branch and backported in the same pr | 03:29:13 |
|  aftix joined the room. | 03:29:23 |
| Tomodachi94 | In reply to@titaniumtown:envs.net
how can I help actually get these PRs through, because I notice there is a lot of stagnation @titaniumtown (they/them) we also have docs on this now that just got added 3 days ago: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-can-i-get-a-committer-to-look-at-my-pr | 03:29:24 |
| Artturin | * It kinda looks like most of the commits without open-webui in them are package updated to packages which are new to that branch and backported in the same pr | 03:29:26 |
| Tomodachi94 | @titaniumtown (they/them) we also have docs on this now that just got added 3 days ago (which is awesome): https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-can-i-get-a-committer-to-look-at-my-pr | 03:29:38 |
| Artturin | * It kinda looks like most of the commits without open-webui in them are package updates to packages which are new to that branch and backported in the same pr | 03:29:41 |
| dotlambda | In reply to @artturin:matrix.org
It kinda looks like most of the commits without open-webui in them are package updates to packages which are new to that branch and backported in the same pr Doesn't look like that to me. The worst offender is duckduckgo-search which saw a major version bump and whose dependencies were changed. | 03:31:12 |
| Artturin | In reply to @artturin:matrix.org
It kinda looks like most of the commits without open-webui in them are package updates to packages which are new to that branch and backported in the same pr Only the duckduckgo-search updates might be ineligible but that depends on if there were breaking things in those updates | 03:31:17 |
 titaniumtown (they/them) | In reply to @tomodachi94:matrix.org
Merged :) I immediately made a PR to update it haha: https://github.com/NixOS/nixpkgs/pull/349910
:ppp | 03:31:48 |
| Tomodachi94 | I'll take a look at that too in a few minutes :) | 03:32:16 |
| dotlambda | In reply to @artturin:matrix.org
Only the duckduckgo-search updates might be ineligible but that depends on if there were breaking things in those updates Did you go through the changelogs, especially of the minor rather than patch updates, to check they aren't breaking? I doubt drupol did | 03:32:33 |
| Tomodachi94 | * I'll take a look at that too in a few minutes :) I won't merge it as fast to give the maintainer a chance to review it as well though | 03:32:44 |
| dotlambda | * Did you go through the changelogs, especially of the minor rather than patch updates, to check they aren't breaking? I doubt drupol did.
EDIT: Never mind, there are none that weren't also added in that PR | 03:33:52 |
| dotlambda | In reply to @artturin:matrix.org
Only the duckduckgo-search updates might be ineligible but that depends on if there were breaking things in those updates Not breaking any other packages in the stable channel is not a sufficient condition for a backport. Who knows whether the API changed | 03:35:18 |
 emily | the duckduckgo-search update is valid under "Services that would fail without up-to-date client software, such as spotify, steam, and discord", see e.g. https://github.com/deedy5/duckduckgo_search/pull/216 | 03:39:38 |
| Artturin | In reply to @robert:funklause.de
Not breaking any other packages in the stable channel is not a sufficient condition for a backport. Who knows whether the API changed I now went through duckduckgo-search releases and they seem fine from a glance | 03:40:16 |
| emily | In reply to @emilazy:matrix.org
the duckduckgo-search update is valid under "Services that would fail without up-to-date client software, such as spotify, steam, and discord", see e.g. https://github.com/deedy5/duckduckgo_search/pull/216 ("The old versions stop working, I have to figure out new ways.") | 03:40:51 |
| emily | only other existing packages i see are open-webui itself and shapely | 03:41:04 |
| emily | shapely is a 0.0.1 bug fix release with a small diff, no knowledge/opinion about open-webui | 03:41:23 |
| dotlambda | open-webui is added in that PR, that's fine | 03:41:51 |
| dotlambda | Looks like it's fine after all but such backports really should provide a rationale | 03:42:20 |
| emily | no, that package was preexisting, but everything else at least seems fine | 03:42:25 |
| dotlambda | In reply to @emilazy:matrix.org
no, that package was preexisting, but everything else at least seems fine Oh you're right | 03:43:00 |
| emily | ah, though it was only backported to 24.05 in August | 03:48:16 |
| emily | and the bump was merged the day after | 03:49:00 |
| emily | so not really any break | 03:49:03 |
