| 20 Oct 2024 |
 SigmaSquadron | i'm not sure why, but something tells me that a committer did something pretty bad. | 03:08:09 |
| SigmaSquadron | must have been the wind | 03:08:35 |
 dotlambda | In reply to @sigmasquadron:matrix.org
i'm not sure why, but something tells me that a committer did something pretty bad. https://github.com/NixOS/nixpkgs/pull/332915 | 03:12:44 |
 Tomodachi94 | In reply to@robert:funklause.de
Do we have a list where violations of the trust we put in committers are documented? I don't think there's anything centralized. There have been comments (thinking of one in particular who I won't name) in the original committer right request issue that explained why someone had the bit removed after someone re-nominated them unknowingly | 03:15:03 |
 titaniumtown (they/them) | In reply to @robert:funklause.de
https://github.com/NixOS/nixpkgs/pull/332915 all PRs will be merged, no exceptions 🫡 | 03:15:09 |
| titaniumtown (they/them) | In reply to @robert:funklause.de
https://github.com/NixOS/nixpkgs/pull/332915 * all PRs will be merged, no exceptions 🫡 /j | 03:15:20 |
| SigmaSquadron | In reply to @robert:funklause.de
https://github.com/NixOS/nixpkgs/pull/332915 yep, that does fall on the category of 'pretty bad'.
But maybe it's best to discuss this with Pol before anything? | 03:15:41 |
| Tomodachi94 | In reply to@titaniumtown:envs.net
all PRs will be merged, no exceptions 🫡 /j Especially breaking changes on stable branches 🫡 | 03:15:46 |
| Tomodachi94 | * Especially breaking changes on stable branches 🫡 /j | 03:16:15 |
| dotlambda | In reply to @sigmasquadron:matrix.org
yep, that does fall on the category of 'pretty bad'.
But maybe it's best to discuss this with Pol before anything? I pinged them in a different Matrix room, they are not in this one. | 03:16:21 |
 Artturin | @robert:funklause.de: you may want to ping pol with the link to this room | 03:25:53 |
| Artturin | * @robert:funklause.de: you may want to ping pol with the link to this room instead | 03:26:07 |
| Artturin | In reply to @robert:funklause.de
https://github.com/NixOS/nixpkgs/pull/332915 It kinda looks like most of the commits without open-webui inn hem are package updated to packages which are new to that branch and backported in the same pr | 03:29:13 |
|  aftix joined the room. | 03:29:23 |
| Tomodachi94 | In reply to@titaniumtown:envs.net
how can I help actually get these PRs through, because I notice there is a lot of stagnation @titaniumtown (they/them) we also have docs on this now that just got added 3 days ago: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-can-i-get-a-committer-to-look-at-my-pr | 03:29:24 |
| Artturin | * It kinda looks like most of the commits without open-webui in them are package updated to packages which are new to that branch and backported in the same pr | 03:29:26 |
| Tomodachi94 | @titaniumtown (they/them) we also have docs on this now that just got added 3 days ago (which is awesome): https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-can-i-get-a-committer-to-look-at-my-pr | 03:29:38 |
| Artturin | * It kinda looks like most of the commits without open-webui in them are package updates to packages which are new to that branch and backported in the same pr | 03:29:41 |
| dotlambda | In reply to @artturin:matrix.org
It kinda looks like most of the commits without open-webui in them are package updates to packages which are new to that branch and backported in the same pr Doesn't look like that to me. The worst offender is duckduckgo-search which saw a major version bump and whose dependencies were changed. | 03:31:12 |
| Artturin | In reply to @artturin:matrix.org
It kinda looks like most of the commits without open-webui in them are package updates to packages which are new to that branch and backported in the same pr Only the duckduckgo-search updates might be ineligible but that depends on if there were breaking things in those updates | 03:31:17 |
| titaniumtown (they/them) | In reply to @tomodachi94:matrix.org
Merged :) I immediately made a PR to update it haha: https://github.com/NixOS/nixpkgs/pull/349910
:ppp | 03:31:48 |
| Tomodachi94 | I'll take a look at that too in a few minutes :) | 03:32:16 |
| dotlambda | In reply to @artturin:matrix.org
Only the duckduckgo-search updates might be ineligible but that depends on if there were breaking things in those updates Did you go through the changelogs, especially of the minor rather than patch updates, to check they aren't breaking? I doubt drupol did | 03:32:33 |
| Tomodachi94 | * I'll take a look at that too in a few minutes :) I won't merge it as fast to give the maintainer a chance to review it as well though | 03:32:44 |
