| 19 Oct 2024 |
 ElvishJerricco | amarshall: Should you and adamcstephens be added as codeowners of the zfs nixos module so you get added to review PRs like this? https://github.com/NixOS/nixpkgs/pull/349560 | 22:16:23 |
 titaniumtown (they/them) | why do some PRs just sit after getting a bunch of approvals, but it's never merged | 23:34:43 |
| titaniumtown (they/them) | I'm trying to get VR working (again) on my machine, and found WiVRn, bam there was a PR from june https://github.com/NixOS/nixpkgs/pull/316975 | 23:35:16 |
| titaniumtown (they/them) | how can I help actually get these PRs through, because I notice there is a lot of stagnation | 23:35:30 |
| 20 Oct 2024 |
 Sam | This issue potentially affects many nodejs packages and has already received two approvals, from the maintainer and from the person who deprecated the alias. Could a committer merge it? https://github.com/NixOS/nixpkgs/pull/349783 | 00:09:10 |
 Tomodachi94 | In reply to@titaniumtown:envs.net
how can I help actually get these PRs through, because I notice there is a lot of stagnation Post in #Nixpkgs Review Requests if it's been longer than a week. If the PR has already been through review, there is also https://discourse.nixos.org/t/prs-already-reviewed/2617 on the Discourse, which is specifically for PRs that are reviewed but not merged. | 02:37:39 |
| Tomodachi94 | That PR in particular might be scaring people away due to the 141 comments on it | 02:38:49 |
| Tomodachi94 | Taking a look at that specific PR right now :) | 02:44:50 |
| titaniumtown (they/them) | In reply to @tomodachi94:matrix.org
Post in #Nixpkgs Review Requests if it's been longer than a week. If the PR has already been through review, there is also https://discourse.nixos.org/t/prs-already-reviewed/2617 on the Discourse, which is specifically for PRs that are reviewed but not merged. thank you for the information. I'm trying my best to give what I can to the community :) | 02:55:58 |
| titaniumtown (they/them) | In reply to @tomodachi94:matrix.org
Taking a look at that specific PR right now :) thank you so much! | 02:56:03 |
| Tomodachi94 | Merged :) | 03:03:25 |
 dotlambda | Do we have a list where violations of the trust we put in committers are documented? | 03:05:20 |
 SigmaSquadron | i'm not sure why, but something tells me that a committer did something pretty bad. | 03:08:09 |
| SigmaSquadron | must have been the wind | 03:08:35 |
| dotlambda | In reply to @sigmasquadron:matrix.org
i'm not sure why, but something tells me that a committer did something pretty bad. https://github.com/NixOS/nixpkgs/pull/332915 | 03:12:44 |
| Tomodachi94 | In reply to@robert:funklause.de
Do we have a list where violations of the trust we put in committers are documented? I don't think there's anything centralized. There have been comments (thinking of one in particular who I won't name) in the original committer right request issue that explained why someone had the bit removed after someone re-nominated them unknowingly | 03:15:03 |
| titaniumtown (they/them) | In reply to @robert:funklause.de
https://github.com/NixOS/nixpkgs/pull/332915 all PRs will be merged, no exceptions 🫡 | 03:15:09 |
| titaniumtown (they/them) | In reply to @robert:funklause.de
https://github.com/NixOS/nixpkgs/pull/332915 * all PRs will be merged, no exceptions 🫡 /j | 03:15:20 |
| SigmaSquadron | In reply to @robert:funklause.de
https://github.com/NixOS/nixpkgs/pull/332915 yep, that does fall on the category of 'pretty bad'.
But maybe it's best to discuss this with Pol before anything? | 03:15:41 |
| Tomodachi94 | In reply to@titaniumtown:envs.net
all PRs will be merged, no exceptions 🫡 /j Especially breaking changes on stable branches 🫡 | 03:15:46 |
| Tomodachi94 | * Especially breaking changes on stable branches 🫡 /j | 03:16:15 |
| dotlambda | In reply to @sigmasquadron:matrix.org
yep, that does fall on the category of 'pretty bad'.
But maybe it's best to discuss this with Pol before anything? I pinged them in a different Matrix room, they are not in this one. | 03:16:21 |
 Artturin | @robert:funklause.de: you may want to ping pol with the link to this room | 03:25:53 |
| Artturin | * @robert:funklause.de: you may want to ping pol with the link to this room instead | 03:26:07 |
| Artturin | In reply to @robert:funklause.de
https://github.com/NixOS/nixpkgs/pull/332915 It kinda looks like most of the commits without open-webui inn hem are package updated to packages which are new to that branch and backported in the same pr | 03:29:13 |
|  aftix joined the room. | 03:29:23 |
| Tomodachi94 | In reply to@titaniumtown:envs.net
how can I help actually get these PRs through, because I notice there is a lot of stagnation @titaniumtown (they/them) we also have docs on this now that just got added 3 days ago: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-can-i-get-a-committer-to-look-at-my-pr | 03:29:24 |
| Artturin | * It kinda looks like most of the commits without open-webui in them are package updated to packages which are new to that branch and backported in the same pr | 03:29:26 |
| Tomodachi94 | @titaniumtown (they/them) we also have docs on this now that just got added 3 days ago (which is awesome): https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-can-i-get-a-committer-to-look-at-my-pr | 03:29:38 |
| Artturin | * It kinda looks like most of the commits without open-webui in them are package updates to packages which are new to that branch and backported in the same pr | 03:29:41 |
