| 19 Oct 2024 |
 Assistant | I'm looking at hyprshot's latest version which added hyprpicker as an option dependency for a feature to work | 17:22:59 |
| Assistant | gating the dependency would still make it build it right? since it has to be an input to the package | 17:23:44 |
 nevivurn | Assuming upstream handled missing dependencies correctly, yeah.
I would say most packages are configured with optional dependencies / features enabled unless the dependency is huge / very rarely used / etc. | 17:25:41 |
| Assistant | If the dependency is missing the package still works, that feature just doesn't | 17:26:57 |
| Assistant | In that case I don't see a benefit of gating it in this case, since it would still be getting pulled just not included in the wrapper's PATH | 17:28:19 |
 Atemu | Assistant: Why would it be pulled if it was disabled? | 19:24:11 |
| Assistant | Is it not? my understanding was that it would still be considered a dependency of the package and thus pulled even if after evaluation it's not used | 19:33:19 |
 symphorien | is it currently ok to remove software from nixpkgs with the upcoming release ? | 19:40:30 |
| symphorien | I did not follow the calendar very closely | 19:40:43 |
| Assistant | In reply to@atemu12:matrix.org
Assistant: Why would it be pulled if it was disabled? if I do
{ stdenvNoCC
, lib
, fetchFromGitHub
, hyprland
, jq
, grim
, slurp
, wl-clipboard
, libnotify
, withFreeze ? true, hyprpicker
, makeWrapper
}:
stdenvNoCC.mkDerivation (finalAttrs: {
pname = "hyprshot";
version = "1.3.0";
src = fetchFromGitHub {
owner = "Gustash";
repo = "hyprshot";
rev = finalAttrs.version;
hash = "sha256-9taTmV357cWglMGuN3NLq3bfNneFthwV6y+Ml4qEeHA=";
};
nativeBuildInputs = [ makeWrapper ];
installPhase = ''
runHook preInstall
install -Dm755 hyprshot -t "$out/bin"
wrapProgram "$out/bin/hyprshot" \
--prefix PATH ":" ${lib.makeBinPath [
hyprland jq grim slurp wl-clipboard libnotify
] ++ lib.optionals withFreeze [ hyprpicker ]}
runHook postInstall
'';
})
then does hyprshot.override { withFreeze = false; } not pull hyprpicker? | 19:44:02 |
| Atemu | Assistant: I can't tell you from this snippet because that fully depends on whether you guard hyprpicker's inclusion in the drv behind the flag or not. It being a function arg doesn't matter if it's never used; remember that Nix is lazy | 19:54:42 |
| Assistant | That is the derivation, but what I'm getting is that my assumption was wrong and I misunderstood what was said earlier, so I will add the flag | 20:00:03 |
 Randy Eckenrode | * It doesn’t seem to work with packages where the version information isn’t easily available. I tried to use it with my out-of-tree FFXIV derivation, but it kept trying to do things that didn’t make sense. To get the Mac client version, I have to parse Sparkle update manifests. Also, old versions are take offline as soon as a new one is released. | 20:03:26 |
| Atemu | Ohh, totally missed that the thing is scrollable. Yes, that'll only include hyprpicker when the flag is set | 21:38:54 |
 nyanbinary 🏳️⚧️ | 
Download image.png | 21:41:59 |
| nyanbinary 🏳️⚧️ | is this just my end or is the channel named scewed up | 21:42:09 |
 ElvishJerricco | amarshall: Should you and adamcstephens be added as codeowners of the zfs nixos module so you get added to review PRs like this? https://github.com/NixOS/nixpkgs/pull/349560 | 22:16:23 |
 titaniumtown (they/them) | why do some PRs just sit after getting a bunch of approvals, but it's never merged | 23:34:43 |
| titaniumtown (they/them) | I'm trying to get VR working (again) on my machine, and found WiVRn, bam there was a PR from june https://github.com/NixOS/nixpkgs/pull/316975 | 23:35:16 |
| titaniumtown (they/them) | how can I help actually get these PRs through, because I notice there is a lot of stagnation | 23:35:30 |
| 20 Oct 2024 |
 Sam | This issue potentially affects many nodejs packages and has already received two approvals, from the maintainer and from the person who deprecated the alias. Could a committer merge it? https://github.com/NixOS/nixpkgs/pull/349783 | 00:09:10 |
 Tomodachi94 | In reply to@titaniumtown:envs.net
how can I help actually get these PRs through, because I notice there is a lot of stagnation Post in #Nixpkgs Review Requests if it's been longer than a week. If the PR has already been through review, there is also https://discourse.nixos.org/t/prs-already-reviewed/2617 on the Discourse, which is specifically for PRs that are reviewed but not merged. | 02:37:39 |
| Tomodachi94 | That PR in particular might be scaring people away due to the 141 comments on it | 02:38:49 |
| Tomodachi94 | Taking a look at that specific PR right now :) | 02:44:50 |
| titaniumtown (they/them) | In reply to @tomodachi94:matrix.org
Post in #Nixpkgs Review Requests if it's been longer than a week. If the PR has already been through review, there is also https://discourse.nixos.org/t/prs-already-reviewed/2617 on the Discourse, which is specifically for PRs that are reviewed but not merged. thank you for the information. I'm trying my best to give what I can to the community :) | 02:55:58 |
| titaniumtown (they/them) | In reply to @tomodachi94:matrix.org
Taking a look at that specific PR right now :) thank you so much! | 02:56:03 |
