!kjdutkOsheZdjqYmqp:nixos.org

Nixpkgs / NixOS contributions

1863 Members
NixOS 24.05 Uakari | #review-requests:nixos.org | https://nixos.org/blog/announcements.html#nixos-23.11 | https://hydra.nixos.org/jobset/nixos/trunk-combined | https://reproducible.nixos.org/ | 24.05 RMs: wegank & Mic92410 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
19 Oct 2024
@hexa:lossy.networkhexamakes it so people editing the derivation can't easily open the urls from their editor07:41:44
@hexa:lossy.networkhexameh07:41:44
@hive:the-apothecary.clubLi-ion changed their display name from ion to Li-ion.08:12:13
@noob_tea:matrix.orgtea
In reply to @phanirithvij:matrix.org
$ rg '\$\{src\.owner\}'

pkgs/data/themes/sddm-astronaut/default.nix
32:    homepage = "https://github.com/${src.owner}/${src.repo}";

pkgs/data/themes/sddm-sugar-dark/default.nix
34:    homepage = "https://github.com/${src.owner}/${pname}";

pkgs/by-name/fl/flake-checker/package.nix
28:    homepage = "https://github.com/${src.owner}/${src.repo}";
29:    changelog = "https://github.com/${src.owner}/${src.repo}/releases/tag/${src.rev}";

pkgs/by-name/gp/gpauth/package.nix
37:    changelog = "https://github.com/${src.owner}/${src.repo}/blob/${src.rev}/changelog.md";
46:    homepage = "https://github.com/${src.owner}/${src.repo}";

pkgs/by-name/ar/artalk/package.nix
23:    url = "https://github.com/${src.owner}/${src.repo}/releases/download/v${version}/artalk_ui.tar.gz";

pkgs/by-name/so/sonarlint-ls/package.nix
92:          LATEST_TAG=$(curl https://api.github.com/repos/${src.owner}/${src.repo}/tags | \

pkgs/by-name/sr/srgn/package.nix
32:    homepage = "https://github.com/${src.owner}/${src.repo}/";
33:    downloadPage = "https://github.com/${src.owner}/${src.repo}/releases/tag/${src.rev}";
34:    changelog = "https://github.com/${src.owner}/${src.repo}/blob/${src.rev}/CHANGELOG.md";

pkgs/development/tools/gomplate/default.nix
21:    "-X github.com/${src.owner}/${pname}/v4/version.Version=${version}"

is this good or should be avoided? mainly asking for pkg meta, and ldflags (go)

I think that it is unnecessary coupling for no reason
08:34:11
@sandro:supersandro.deSandro 🐧If I can't open URLs in review without copy pasting them together, I usually don't open them and just ask questions instead of answering things myself10:35:57
@sandro:supersandro.deSandro 🐧Also that's a bit in the same direction that is substituting pname wherever you can10:36:15
@jwillikers:matrix.orgjwillikers joined the room.12:06:18
@hexa:lossy.networkhexa
In reply to @sandro:supersandro.de
If I can't open URLs in review without copy pasting them together, I usually don't open them and just ask questions instead of answering things myself
not quite the same reaction from me, but I'm more annoyed that the contribution didn't meet me half way 🙂
12:39:37
@sandro:supersandro.deSandro 🐧https://www.youtube.com/watch?v=n02efead1C414:58:54
@misuzu:matrix.orgmisuzukernel 6.6.57 broke tailscale exit-node functionality...15:52:47
@k900:0upti.meK900https://lore.kernel.org/netfilter-devel/20241019-xtables-typos-v2-1-6b8b1735dc8e@0upti.me/T/#u15:53:37
@assistant:pygmalion.chatAssistantWhat's the policy on including optional dependencies in packages?17:17:20
@hexa:lossy.networkhexa depends a bit on the package ecosystem, but you can expose withFeature flags 17:21:08
@hexa:lossy.networkhexaand guard the inclusion based on that17:21:16
@assistant:pygmalion.chatAssistant I'm looking at hyprshot's latest version which added hyprpicker as an option dependency for a feature to work 17:22:59
@assistant:pygmalion.chatAssistantgating the dependency would still make it build it right? since it has to be an input to the package17:23:44
@nevivurn:nevi.devnevivurnAssuming upstream handled missing dependencies correctly, yeah. I would say most packages are configured with optional dependencies / features enabled unless the dependency is huge / very rarely used / etc.17:25:41
@assistant:pygmalion.chatAssistantIf the dependency is missing the package still works, that feature just doesn't17:26:57
@assistant:pygmalion.chatAssistantIn that case I don't see a benefit of gating it in this case, since it would still be getting pulled just not included in the wrapper's PATH17:28:19
@atemu12:matrix.orgAtemu Assistant: Why would it be pulled if it was disabled? 19:24:11

Show newer messages


Back to Room ListRoom Version: 6