| 21 May 2021 |
 sephi | Thanks, I’ll try that | 12:09:59 |
|  jschievink joined the room. | 12:10:07 |
| jschievink | I was recently added to the "Nixpkgs Maintainers" and am trying to figure out what that means | 12:11:34 |
| jschievink | According to https://github.com/NixOS/rfcs/blob/master/rfcs/0039-unprivileged-maintainer-teams.md I should not be able to close PRs and issues, but it looks like I can | 12:11:48 |
| jschievink | I haven't found any documentation about how to get changes merged that I've approved | 12:12:39 |
|  Domen Kožar joined the room. | 12:14:55 |
| jschievink | The RFC also says: | 12:16:48 |
| jschievink |
OfBorg will identify PRs which are approved by their maintainers, and add a special label approved-by-maintainer.
| 12:16:49 |
| jschievink | but that doesn't seem to happen | 12:17:08 |
 vika (she/her) 🏳️⚧️ | In reply to @jschievink:matrix.org
According to https://github.com/NixOS/rfcs/blob/master/rfcs/0039-unprivileged-maintainer-teams.md I should not be able to close PRs and issues, but it looks like I can Every member of the organization can, it's a GitHub thing I assume. I as a maintainer strive to wield this power wisely and only close issues that are fixed by me | 12:18:14 |
| vika (she/her) 🏳️⚧️ | * Every member of the organization can, it's a GitHub thing I assume. I as a maintainer strive to wield this power responsibly and only close issues that are fixed by me | 12:18:39 |
| vika (she/her) 🏳️⚧️ | Actually I think it kinda makes sense for a maintainer to be able to close issues related to their things | 12:19:59 |
| vika (she/her) 🏳️⚧️ | I've never had a single problem occur to the package I'm named maintainer for | 12:20:25 |
| vika (she/her) 🏳️⚧️ | * I've never had a single problem occur to the package I'm named maintainer for though, so I help with other issues | 12:20:42 |
| vika (she/her) 🏳️⚧️ | For example, I've pushed some fixes related to my production workloads on aarch64 - it sometimes feels like I'm the only one who runs some of the services packaged in NixOS in production though | 12:21:28 |
|  nazarii joined the room. | 12:21:42 |
| vika (she/her) 🏳️⚧️ | For example, nobody except me noticed that one time when rspamd on aarch64 got broken because of a dependency failure. I was the one to notice it (because I'm using it in production and one update suddenly broke my build - it's a good thing it didn't brick my production setup!), I was the one to file an issue | 12:22:40 |
| vika (she/her) 🏳️⚧️ | And then I figured it out and fixed it myself. And closed the issue... | 12:22:51 |
| vika (she/her) 🏳️⚧️ | Too bad you can't become a maintainer for a package on a certain architecture! | 12:23:31 |
 symphorien | few people use aarch64, it's great that you fix it | 12:23:38 |
| vika (she/her) 🏳️⚧️ | * For example, I've pushed some fixes related to my production workloads on aarch64 - it sometimes feels like I'm the only one who runs some of the services packaged in NixOS in production though | 12:23:49 |
| vika (she/her) 🏳️⚧️ | It's just that if I don't fix it, nobody would | 12:24:04 |
| vika (she/her) 🏳️⚧️ | Who in the world runs a production mail server on a Raspberry Pi? | 12:24:18 |
| vika (she/her) 🏳️⚧️ | Well, I do, so I'm fixing everything that prevents me from doing it | 12:24:45 |
| symphorien | hehe | 12:24:56 |
| jschievink | That's pretty cool though :) | 12:25:16 |
| jschievink | how do I get something merged that I've approved as the package maintainer? | 12:25:42 |
 Sandro | does that highlighting work?
let pkgs = import <nixos-unstable> { };
in pkgs.ocamlPackages.buildDunePackage rec {
pname = "comby";
version = "1.5.1";
useDune2 = true;
minimumOcamlVersion = "4.11.0";
src = pkgs.fetchFromGitHub {
owner = "comby-tools";
repo = pname;
rev = version;
sha256 = "1ipfrr6n1jyyryhm9zpn8wwgzfac1zgbjdjzrm00qcwc17r8x2hf";
};
buildInputs = [
pkgs.zlib
pkgs.pkg-config-unwrapped
pkgs.ocamlPackages.ppx_deriving
pkgs.ocamlPackages.ppx_deriving_yojson
pkgs.ocamlPackages.ppx_sexp_conv
pkgs.ocamlPackages.ppx_jane
pkgs.ocamlPackages.ppx_expect
pkgs.ocamlPackages.dune-configurator
pkgs.ocamlPackages.lwt
pkgs.ocamlPackages.parany
pkgs.ocamlPackages.patience_diff
pkgs.ocamlPackages.core
pkgs.ocamlPackages.toml
pkgs.ocamlPackages.shell
pkgs.ocamlPackages.cohttp-lwt-unix
];
}
| 12:34:03 |
| Sandro | yeah, but it thinks http://pkgs.ocamlpackages.shell/ is a domain 🤔 | 12:34:23 |
 sterni | In reply to @jschievink:matrix.org
how do I get something merged that I've approved as the package maintainer? reviewing it is good first step, eventually someone with commit bit comes along and merges it usually. There are usually also threads on discourse and similar where you can post PRs that seem to have been forgotten | 12:38:20 |
