| 7 Nov 2022 |
hexa | https://github.com/NixOS/nixpkgs/pull/200075/files | 20:15:56 |
hexa | can someone review this? | 20:16:01 |
hexa | not sure how referencing the shell script is supposed to work here | 20:16:24 |
ryantm | @hexa you can test it with nix-shell maintainers/scripts/update.nix --argstr package zigbee2mqtt | 20:21:40 |
hexa | ah great | 20:22:02 |
hexa | wasn't sure, but that makes it error out because the script relies on being in the correct path 🙂 | 20:22:34 |
| 8 Nov 2022 |
j-k | I generally use -I nixpkgs=./. since it's being executed at the nixpkgs root. Rather than ../../../../ from where the file is | 09:53:19 |
hexa | we cd to dirname $0 now, so not an issue | 11:55:44 |
hexa | it gets executed from the root when nix-shell is run, but cds to the package dir to do the work in there | 11:56:26 |
j-k | you can't cd to dirname $0 before the nix-shell shebang which is what I'm referring to | 11:56:27 |
hexa | which is why he dropped -I nixpkgs= entirely | 11:56:48 |
j-k | I much prefer knowing which versions of packages the update script will use, but to each their own | 11:57:36 |
hexa | it will mostly be updated by r-ryantm now, so 🤷 | 11:58:06 |
Sandro 🐧 | In reply to @j-k:matrix.org I much prefer knowing which versions of packages the update script will use, but to each their own unless you have areally old nixpkgs channel/flake registry entry then this should not matter to much | 12:30:52 |
Sandro 🐧 | but if you are using master there is a higher chance you need to build dependencies | 12:31:16 |
| 14 Nov 2022 |
hexa | we are going to want changelogs in package bump commit messages soon | 17:00:01 |
hexa | via https://github.com/NixOS/nixpkgs/pull/200922 | 17:00:09 |
hexa | nix-update has added support today and it will be included in its upcoming version | 17:00:24 |
hexa | would be nice if nixpkgs-update would catch up 🙂 | 17:00:41 |
hexa | it's evaluating meta.changelog already if I'm not mistaken | 17:01:16 |
ryantm | @hexa we had this feature at one point, but it was removed because of a fear that it made the commits too big. | 17:01:19 |
hexa | the commit messages? | 17:01:35 |
ryantm | Yeah, sticking the GitHub changelog into the commit message. | 17:01:55 |
hexa | no, just the URL | 17:02:05 |
ryantm | Oh, okay sure. | 17:02:26 |
hexa | the rationale should be pretty straight forward, but it's in that PR up there 😛 | 17:02:51 |
| 16 Nov 2022 |
| @omlet:matrix.org joined the room. | 20:34:01 |
| 17 Nov 2022 |
| vcunat joined the room. | 10:47:13 |
| Mindavi joined the room. | 11:51:19 |
| 18 Nov 2022 |
| Wanja Hentze joined the room. | 08:51:16 |