In reply to @zowoq:matrix.org

If you want the comment to work need to fix meta.position:

❯ nix eval -f. vmagent.meta.position
"/Users/zowoq/src/nixpkgs/pkgs/by-name/vi/victoriametrics/package.nix:87"

diff --git a/pkgs/by-name/vm/vmagent/package.nix b/pkgs/by-name/vm/vmagent/package.nix
index f31526026319..612144762d6f 100644
--- a/pkgs/by-name/vm/vmagent/package.nix
+++ b/pkgs/by-name/vm/vmagent/package.nix
@@ -3,7 +3,7 @@
 # This package is build out of the victoriametrics package.
 # so no separat update prs are needed for vmagent
 # nixpkgs-update: no auto update
-lib.addMetaAttrs { mainProgram = "vmagent"; } (
+lib.addMetaAttrs { mainProgram = "vmagent"; position = toString ./package.nix + ":1"; } (
   victoriametrics.override {
     withServer = false;
     withVictoriaLogs = false;

❯ nix eval -f. vmagent.meta.position
"/Users/zowoq/src/nixpkgs/pkgs/by-name/vm/vmagent/package.nix:1"

Could add it to the skiplist instead:
https://github.com/nix-community/nixpkgs-update/blob/main/src/Skiplist.hs

In reply to @zowoq:matrix.org

If you want the comment to work need to fix meta.position:

❯ nix eval -f. vmagent.meta.position
"/Users/zowoq/src/nixpkgs/pkgs/by-name/vi/victoriametrics/package.nix:87"

diff --git a/pkgs/by-name/vm/vmagent/package.nix b/pkgs/by-name/vm/vmagent/package.nix
index f31526026319..612144762d6f 100644
--- a/pkgs/by-name/vm/vmagent/package.nix
+++ b/pkgs/by-name/vm/vmagent/package.nix
@@ -3,7 +3,7 @@
 # This package is build out of the victoriametrics package.
 # so no separat update prs are needed for vmagent
 # nixpkgs-update: no auto update
-lib.addMetaAttrs { mainProgram = "vmagent"; } (
+lib.addMetaAttrs { mainProgram = "vmagent"; position = toString ./package.nix + ":1"; } (
   victoriametrics.override {
     withServer = false;
     withVictoriaLogs = false;

❯ nix eval -f. vmagent.meta.position
"/Users/zowoq/src/nixpkgs/pkgs/by-name/vm/vmagent/package.nix:1"

Could add it to the skiplist instead:
https://github.com/nix-community/nixpkgs-update/blob/main/src/Skiplist.hs

it seems that setting the position fixes my overall issue. Tho not being on the ignored list but complaining before that the old version is not defined in the master derivation (as those are defined on the overriden ones).

I suspect that nixpkgs-update might should check for ignores first, and then for sanity [as it would at least in this case not result in a faulty error log].

Tho it still fine for my result.
ill keep the ignore comment still, so that the initial intention is clear why meta.position is added.

it seems that setting the position fixes my overall issue. Tho not being on the ignored list but complaining before that the old version is not defined in the master derivation (as those are defined on the overriden ones).

I suspect that nixpkgs-update might should check for ignores first, and then for sanity [as it would at least in this case not result in a faulty error log].

Tho it still fine for my result.
ill keep the ignore comment still, so that the initial intention is clear why meta.position is added.

Or do you have other suggestions for that? 🙂

it seems that setting the position fixes my overall issue. Tho not being on the ignored list but complaining before that the old version is not defined in the master derivation (as those are defined on the overriden ones).

I suspect that nixpkgs-update might should check for ignores first, and then for sanity [as it would at least in this case not result in a faulty error log].

Tho it still fine for my result.
ill could keep the ignore comment still, so that the initial intention is clear why meta.position is added.

Tho i start to feel that adding it to nixpkgs-updates internal skiplist is kind of more understandable.

Or do you have other suggestions for that? 🙂