19 Sep 2023 |
ryantm |
| 19:44:27 |
ryantm | * [ryantm@replit1:~/p/nixpkgs]$ EDITOR=echo nix edit -f . kicad
/home/ryantm/p/nixpkgs/pkgs/applications/science/electronics/kicad/default.nix
[ryantm@replit1:~/p/nixpkgs]$ cat /home/ryantm/p/nixpkgs/pkgs/applications/science/electronics/kicad/default.nix | grep gnome
, gnome
"--prefix XDG_DATA_DIRS : ${gnome.adwaita-icon-theme}/share" | 19:44:32 |
Artturin | the check here is wrong https://github.com/ryantm/nixpkgs-update/blob/8fedf8f6f29280578e335bf4483c9f88d4bcdbaa/src/Skiplist.hs#L151 | 19:45:39 |
Artturin | just a naive grep | 19:45:49 |
Artturin | maybe a better way would be to check for teams.gnome.members | 19:47:29 |
Artturin | still has false positives but way less | 19:47:37 |
ryantm | https://github.com/ryantm/nixpkgs-update/commit/2fda8bcb73776c3e11c0155fa15e138a71e1f189 | 19:49:37 |
evils | In reply to @artturin:matrix.org the check here is wrong https://github.com/ryantm/nixpkgs-update/blob/8fedf8f6f29280578e335bf4483c9f88d4bcdbaa/src/Skiplist.hs#L151 huh, i see kicad a bit further down there, what does binariesStickAround imply? | 19:54:51 |
Artturin | In reply to @evils:nixos.dev huh, i see kicad a bit further down there, what does binariesStickAround imply? https://github.com/ryantm/nixpkgs-update/commit/7ff121794ec221b4378b1dfb2032fe4e65fc216d | 19:59:25 |
Artturin | the commands don't properly exit | 19:59:51 |
Artturin | * the binaries don't properly exit | 20:00:01 |
evils | ah, https://gitlab.com/kicad/code/kicad/-/issues/6957 | 20:00:39 |
Artturin | doesn't seem to skip the update | 20:00:42 |
Artturin | only running the bin | 20:00:44 |
21 Sep 2023 |
| dedmunwalk joined the room. | 23:08:16 |
22 Sep 2023 |
| K900 changed their profile picture. | 09:43:48 |
23 Sep 2023 |
evils | euhm, does maintainers/scripts/update.nix not use uncommitted changes to an update.sh ? | 19:06:02 |
evils | does anything use the stuff in the json output of update scripts?
i've added that output and filled in my version strings for oldVersion and newVersions (date)
but update.nix still uses the version the package uses (substring of the commit hash instead of date to avoid rebuilding if a no-op update happens after midnight) | 20:58:44 |
evils | * does anything use the stuff in the json output of update scripts?
i've added that output and filled in my version strings for oldVersion and newVersions (date)
but in its commit update.nix still uses the version the package uses (substring of the commit hash instead of date to avoid rebuilding if a no-op update happens after midnight) | 20:59:36 |
evils | nvm, missed i have to explicitly declare "commit" as a supported feature | 22:07:32 |
evils | In reply to @evils:nixos.dev euhm, does maintainers/scripts/update.nix not use uncommitted changes to an update.sh ? seems like it, quite easy to get stuck wondering why local changes have no effect xD | 22:40:33 |
evils | also odd, if i delete my versions.nix the updating crashes, while manual invocation of update.sh will just regenerate the file | 22:42:25 |
24 Sep 2023 |
evils | an actual question: update.nix seems to only attempt to update kicad and not kicad-unstable when asked to update by maintainer is there a specific reason for that and will r-ryantm attempt to update kicad-unstable ? | 04:09:33 |
| mib 🥐 joined the room. | 12:23:11 |
Artturin | In reply to @evils:nixos.dev an actual question: update.nix seems to only attempt to update kicad and not kicad-unstable when asked to update by maintainer is there a specific reason for that and will r-ryantm attempt to update kicad-unstable ? $ nix-shell maintainers/scripts/update.nix --argstr package kicad-unstable
this derivation will be built:
/nix/store/sqhsd1a7q02wmsscynhfij3nsh14q3rb-packages.json.drv
building '/nix/store/sqhsd1a7q02wmsscynhfij3nsh14q3rb-packages.json.drv'...
Going to be running update for following packages:
- kicad-unstable-e0d4cf2d5b
Press Enter key to continue...
Running update for:
- kicad-unstable-e0d4cf2d5b: UPDATING ...
seems ok, did not let it finish
| 16:18:49 |
Artturin | https://r.ryantm.com/log/kicad-unstable/2023-07-23.log | 16:18:54 |
Artturin |
Do not update GNOME during a release cycle
| 16:19:02 |
Artturin | which is the issue we fixed previously | 16:19:07 |
Artturin | so next update should work | 16:19:19 |
evils | yea, it already attempted an update of stable
but that's wrong due to my update.sh
https://github.com/NixOS/nixpkgs/pull/256786
i've fixed that, but it's built on top of my kicad-testing branch | 16:19:47 |