| 25 Dec 2024 |
 🐰 xiaoxiangmoe | Maybe I should create a PR for fetchFromGitHub to support update both CI_COMMIT_SHA and version? | 18:36:57 |
 K900 | No, we should not be encouraging people to hardcode git revisions in random places | 18:39:47 |
| 🐰 xiaoxiangmoe | How about this?
src = fetchFromGitHub {
owner = "konoui";
repo = "lipo";
tag = "v${version}";
rev = "4f0dadbf38ee4cf4cc38cbc232b7708fddf965bc";
hash = "sha256-lZgOoN+oibo2h6bw5KHXuiwQvQecTQiqu400sGfaMi0=";
}
| 18:41:27 |
| K900 | That is completely duplicate information | 18:41:58 |
| 🐰 xiaoxiangmoe | tag may change | 18:42:18 |
| 🐰 xiaoxiangmoe | rev is the only source of truth | 18:42:27 |
| K900 | Then you shouldn't provide the tag | 18:42:39 |
| 🐰 xiaoxiangmoe | But the tag is needed for version | 18:42:58 |
| 🐰 xiaoxiangmoe | nixpkg need version field | 18:43:06 |
| K900 | Look | 18:43:11 |
| K900 | We can't be making accommodations in nixpkgs for every stupid decision an upstream makes | 18:43:29 |
| 🐰 xiaoxiangmoe | Okay | 18:43:50 |
| 🐰 xiaoxiangmoe | Also, builtins.fetchGit { url= "https://github.com/konoui/lipo.git"; } can provide lastModified, lastModifiedDate, rev, shortRev attr | 18:47:52 |
| 🐰 xiaoxiangmoe | Should fetchFromGitHub also provide this? | 18:48:04 |
| 🐰 xiaoxiangmoe | nix-repl> builtins.fetchGit { url= "https://github.com/konoui/lipo.git"; }
copying '«git+https://github.com/konoui/lipo.git?exportIgnore=1&ref=refs/heads/main&rev=d405c7e62772120bf98ea326b26799bde8d5a128»«unkn{
lastModified = 1735092575;
lastModifiedDate = "20241225020935";
narHash = "sha256-T4V6VDjwMJ1/uopxbotrCgjNkG8lc3ecYKWRjqT3GnU=";
outPath = "/nix/store/na175bylllrcnn0yq8irfj9q7w3xhh2k-source";
rev = "d405c7e62772120bf98ea326b26799bde8d5a128";
revCount = 134;
shortRev = "d405c7e";
submodules = false;
}
| 18:48:28 |
 linj | In reply to @k900:0upti.me
Not guaranteed, technically I am curious why removing .git does not guarante reproducibility. Could you elaborate? | 18:52:23 |
