| 22 Sep 2022 |
zonnebloem | ty | 20:36:11 |
ryantm | Looks like it is currently failing to build with the error
package github.com/Khan/genqlient: no Go files in /build/source/vendor/github.com/Khan/genqlient
| 20:36:54 |
zonnebloem | I tried looking for a cause. The package's repo mentions genqlient long before the build failures.
So during the nix build the go files were not moved? | 21:12:55 |
| 5 Oct 2022 |
| Rosuavio joined the room. | 19:08:06 |
| 9 Oct 2022 |
| @rdfg77:kde.org joined the room. | 05:45:57 |
@rdfg77:kde.org | Hi, I added a updateScript for vscode python extension but it seems it's not checked by the bot. Can you help me? | 05:49:23 |
| 10 Oct 2022 |
ryantm | linsui: It looks like the code that searches for updatescripts isn't finding it https://github.com/nix-community/infra/blob/bb8131db4f86eade543160cc31e36a6847f45122/build02/packages-with-update-script.nix | 14:45:29 |
ryantm | linsui: Looks like maybe we need to add something related to "recurseForDerivations"? I'm not that familiar with what that is. | 14:47:51 |
ryantm | Oh never mind, it is already doing that for vscode-extensions | 14:49:26 |
ryantm | linsui: What's the attrpath for the thing you want to update? | 14:51:38 |
ryantm | vscode-extensions.ms-python.python ? | 14:52:36 |
@rdfg77:kde.org | It's vscode-extensions.ms-python.python. | 14:52:52 |
@rdfg77:kde.org | Yes. | 14:52:57 |
ryantm | Not sure why it isn't getting picked up by that code. Feel free to try to figure it out yourself, or I'll try to look later. | 14:53:47 |
@rdfg77:kde.org | I guess I need to check if https://github.com/nix-community/infra/blob/bb8131db4f86eade543160cc31e36a6847f45122/build02/packages-with-update-script.nix can output the attrpath? I'll have a try. | 14:55:00 |
ryantm | It was copied from here: https://github.com/NixOS/nixpkgs/blob/master/maintainers/scripts/update.nix | 15:09:23 |
| 18 Oct 2022 |
@rdfg77:kde.org | ryantm: I put the script into the same directory as update.nix and use pkgs = import ./../../default.nix { };. I got
vscode 0 1
vscode-extensions.ms-python.python 0 1
vscode-extensions.vadimcn.vscode-lldb 0 1
vscodium 0 1
The vscode-lldb is not auto updated, either.
| 08:00:50 |
| 19 Oct 2022 |
| @waldyrious:matrix.org joined the room. | 08:47:13 |
| 7 Nov 2022 |
hexa | https://github.com/NixOS/nixpkgs/pull/200075/files | 20:15:56 |
hexa | can someone review this? | 20:16:01 |
hexa | not sure how referencing the shell script is supposed to work here | 20:16:24 |
ryantm | @hexa you can test it with nix-shell maintainers/scripts/update.nix --argstr package zigbee2mqtt | 20:21:40 |
hexa | ah great | 20:22:02 |
hexa | wasn't sure, but that makes it error out because the script relies on being in the correct path 🙂 | 20:22:34 |
| 8 Nov 2022 |
j-k | I generally use -I nixpkgs=./. since it's being executed at the nixpkgs root. Rather than ../../../../ from where the file is | 09:53:19 |
hexa | we cd to dirname $0 now, so not an issue | 11:55:44 |
hexa | it gets executed from the root when nix-shell is run, but cds to the package dir to do the work in there | 11:56:26 |
j-k | you can't cd to dirname $0 before the nix-shell shebang which is what I'm referring to | 11:56:27 |
hexa | which is why he dropped -I nixpkgs= entirely | 11:56:48 |
j-k | I much prefer knowing which versions of packages the update script will use, but to each their own | 11:57:36 |