23 Mar 2025 |
Gaétan Lepage | I'll have a look | 21:12:26 |
SigmaSquadron | Gaétan Lepage: Are you sure that this is necessary? (especially for a new contributor)
nixpkgs-update automatically fetches new releases from packages published on GitHub without an explicit passthru.updateScript set.
| 21:15:25 |
Gaétan Lepage | In reply to @sigmasquadron:matrix.org
Gaétan Lepage: Are you sure that this is necessary? (especially for a new contributor)
nixpkgs-update automatically fetches new releases from packages published on GitHub without an explicit passthru.updateScript set.
I didn't know that! I thought that specifying updateScript was necessary for the bot to work. (except for python packages where this is set by default). | 21:16:58 |
SigmaSquadron | As far as I understand, that's what the documentation means by "It uses package repository information from Repology.org, the GitHub releases API, and the package passthru.updateScript to generate a lists of outdated packages." (emphasis mine)
I'm not exactly sure if that's for some internal "list of outdated packages" or the actual update itself, so take this with a grain of salt. | 21:20:14 |
SigmaSquadron | I'm just more concerned about making such reviews for first-time contributors; we can merge a package as-is, and add non-essential improvements later on. | 21:21:28 |
SigmaSquadron | * I'm just more concerned about making such reviews for first-time contributors; we can merge a package as-is, and add non-essential improvements later on. (ditto for using lib.cmakeBool , since that library is really only used in situations where the boolean isn't always true or false . The string flag is fine.) | 21:23:14 |
24 Mar 2025 |
Austin Horstman | In reply to @sigmasquadron:matrix.org
Gaétan Lepage: Are you sure that this is necessary? (especially for a new contributor)
nixpkgs-update automatically fetches new releases from packages published on GitHub without an explicit passthru.updateScript set.
It’s not necessary for the bot, but can be helpful for maintainers running the update scripts in repo | 12:23:10 |
25 Mar 2025 |
| aleksana 🏳️⚧️ (force me to bed after 18:00 UTC) changed their display name from aleksana (force me to bed after 18:00 UTC) to aleksana 🏳️⚧️ (force me to bed after 18:00 UTC). | 17:00:10 |
31 Mar 2025 |
| xenos76 joined the room. | 11:30:38 |
xenos76 | Hi, I'm facing the following problem while updating hplip :
error: builder for '/nix/store/3szdhxqbxk0npbf1ihqkdhqb7qidv6gj-hplip-3.24.4-plugin.run.drv' failed with exit code 1;
last 7 log lines:
>
> trying https://developers.hp.com/sites/default/files/hplip-3.24.4-plugin.run
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
> curl: (22) The requested URL returned error: 403
> error: cannot download hplip-3.24.4-plugin.run from any mirror
In my understanding, the issue should was already addressed with: https://github.com/NixOS/nixpkgs/issues/391727 https://github.com/NixOS/nixpkgs/pull/391529 but today's update from 24.11 failed: how can I check if the patch made it to the stable branch? Am I missing something else?
| 11:37:56 |
1 Apr 2025 |
sorrel | In reply to @xenos76:matrix.org
Hi, I'm facing the following problem while updating hplip :
error: builder for '/nix/store/3szdhxqbxk0npbf1ihqkdhqb7qidv6gj-hplip-3.24.4-plugin.run.drv' failed with exit code 1;
last 7 log lines:
>
> trying https://developers.hp.com/sites/default/files/hplip-3.24.4-plugin.run
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
> curl: (22) The requested URL returned error: 403
> error: cannot download hplip-3.24.4-plugin.run from any mirror
In my understanding, the issue should was already addressed with: https://github.com/NixOS/nixpkgs/issues/391727 https://github.com/NixOS/nixpkgs/pull/391529 but today's update from 24.11 failed: how can I check if the patch made it to the stable branch? Am I missing something else?
that PR targets the master branch, so it will not hit the stable channels ever. (you can see its progress towards e.g. nixos-unstable at https://nixpk.gs/pr-tracker.html?pr=391529)
I've now tagged it for backport to 24.11, so a backport PR has been automatically created: https://github.com/NixOS/nixpkgs/pull/395044 however, this will still need to be manually merged and make its way through hydra before it's available in e.g. the nixos-24.11 branch | 00:18:53 |
Perchun Pak [don't ping; dm instead] | you can track it here https://nixpk.gs/pr-tracker.html?pr=395044 | 12:34:49 |
| Sandro 🐧 changed their display name from Sandro 🐧 to Sandro 🐧 [c3d2]. | 13:56:16 |
| Sandro 🐧 changed their display name from Sandro 🐧 [c3d2] to "Sandro [c3d2]". | 13:57:02 |
| Sandro 🐧 changed their display name from "Sandro [c3d2]" to Sandro 🐧 [c3d2]. | 13:57:35 |
| Sandro 🐧 changed their display name from Sandro 🐧 [c3d2] to Sandro 🐧. | 13:58:46 |
xenos76 | Thanks | 20:58:24 |
3 Apr 2025 |
zitrone | r-ryantm was able to update my package https://nixpkgs-update-logs.nix-community.org/wl-gammarelay-rs/2025-04-03.log
but it didn't open a pr for it | 13:00:04 |
5 Apr 2025 |
| zexu joined the room. | 13:09:08 |
11 Apr 2025 |
| @ambroisie:belanyi.fr left the room. | 22:08:49 |
13 Apr 2025 |
| Bot_wxt1221 joined the room. | 13:32:29 |
15 Apr 2025 |
| Indrek joined the room. | 11:55:07 |
Indrek | This is an interesting failure, seems to perform the update sucessfully but unable to commit the result after https://nixpkgs-update-logs.nix-community.org/bitwarden-desktop/2025-04-15.log
also found another one at https://nixpkgs-update-logs.nix-community.org/tabnine/2025-04-10.log | 13:22:39 |
Sandro 🐧 | No auto update branch exists
Successfully finished processing
Received ExitFailure 1 when running
Raw command: git commit -am "bitwarden-desktop: 2025.2.0 -> 2025.3.1"
Standard output:
On branch auto-update/bitwarden-desktop
nothing to commit, working tree clean
| 15:03:08 |
Perchun Pak [don't ping; dm instead] | this is probably because the update script commits changes and r-ryantm tries to create a second commit
https://github.com/NixOS/nixpkgs/blob/2631b0b7abcea6e640ce31cd78ea58910d31e650/pkgs/by-name/bi/bitwarden-desktop/package.nix#L225
https://github.com/NixOS/nixpkgs/blob/2631b0b7abcea6e640ce31cd78ea58910d31e650/pkgs/by-name/ta/tabnine/update.sh#L46 | 17:57:02 |
Indrek | Yeah, that's most likely it. I'm pretty new to all things nix so it's difficult to say if this is a nixpkgs issue or nixpkgs-update issue.
I guess the automation could soft reset the git state back to what it started with and then perform a commit of its own, but this sounds a little hacky. On the other hand nixpkgs could simply state that update scripts should not be allowed to perform git operations on the repository by default and then things would just work on r-ryantm side. There's probably other solutions may exist as well, but this is just to illustrate my point that it's not clear to me what's the next step from here. | 21:45:10 |
19 Apr 2025 |
| jopejoe1 changed their display name from jopejoe1 to jopejoe1 (4094@eh22). | 12:59:35 |
21 Apr 2025 |
| Grimmauld (any/all) joined the room. | 10:54:13 |
22 Apr 2025 |
| Thomas joined the room. | 17:31:10 |
1 May 2025 |
| Rosuavio changed their display name from Rosario Pulella to Rosuavio. | 20:09:22 |