Sender | Message | Time |
---|---|---|
23 Mar 2025 | ||
In reply to @glepage:matrix.orgIt is more accurate in some cases, and wrong in others. Would be good to disable, in my opinion. PR probably to the nixpkgs-update repo? | 20:45:00 | |
Yes, as there is no clear consensus on which one is best, I don't think that the update script should enforce one of them. | 21:11:56 | |
I'll have a look | 21:12:26 | |
Gaétan Lepage: Are you sure that this is necessary? (especially for a new contributor)
| 21:15:25 | |
In reply to @sigmasquadron:matrix.orgI didn't know that! I thought that specifying updateScript was necessary for the bot to work. (except for python packages where this is set by default). | 21:16:58 | |
As far as I understand, that's what the documentation means by "It uses package repository information from Repology.org, the GitHub releases API, and the package passthru.updateScript to generate a lists of outdated packages." (emphasis mine) I'm not exactly sure if that's for some internal "list of outdated packages" or the actual update itself, so take this with a grain of salt. | 21:20:14 | |
I'm just more concerned about making such reviews for first-time contributors; we can merge a package as-is, and add non-essential improvements later on. | 21:21:28 | |
* I'm just more concerned about making such reviews for first-time contributors; we can merge a package as-is, and add non-essential improvements later on. (ditto for using lib.cmakeBool , since that library is really only used in situations where the boolean isn't always true or false . The string flag is fine.) | 21:23:14 | |
24 Mar 2025 | ||
In reply to @sigmasquadron:matrix.orgIt’s not necessary for the bot, but can be helpful for maintainers running the update scripts in repo | 12:23:10 | |
25 Mar 2025 | ||
17:00:10 | ||
31 Mar 2025 | ||
11:30:38 | ||
Hi,
In my understanding, the issue should was already addressed with: | 11:37:56 | |
1 Apr 2025 | ||
In reply to @xenos76:matrix.org that PR targets the I've now tagged it for backport to 24.11, so a backport PR has been automatically created: https://github.com/NixOS/nixpkgs/pull/395044 | 00:18:53 | |
you can track it here https://nixpk.gs/pr-tracker.html?pr=395044 | 12:34:49 | |
13:56:16 | ||
13:57:02 | ||
13:57:35 | ||
13:58:46 | ||
Thanks | 20:58:24 | |
3 Apr 2025 | ||
r-ryantm was able to update my package https://nixpkgs-update-logs.nix-community.org/wl-gammarelay-rs/2025-04-03.log but it didn't open a pr for it | 13:00:04 | |
5 Apr 2025 | ||
13:09:08 | ||
11 Apr 2025 | ||
22:08:49 | ||
13 Apr 2025 | ||
13:32:29 | ||
15 Apr 2025 | ||
11:55:07 | ||
This is an interesting failure, seems to perform the update sucessfully but unable to commit the result after https://nixpkgs-update-logs.nix-community.org/bitwarden-desktop/2025-04-15.log also found another one at https://nixpkgs-update-logs.nix-community.org/tabnine/2025-04-10.log | 13:22:39 | |
| 15:03:08 | |
this is probably because the update script commits changes and r-ryantm tries to create a second commit https://github.com/NixOS/nixpkgs/blob/2631b0b7abcea6e640ce31cd78ea58910d31e650/pkgs/by-name/bi/bitwarden-desktop/package.nix#L225 https://github.com/NixOS/nixpkgs/blob/2631b0b7abcea6e640ce31cd78ea58910d31e650/pkgs/by-name/ta/tabnine/update.sh#L46 | 17:57:02 | |
Yeah, that's most likely it. I'm pretty new to all things nix so it's difficult to say if this is a nixpkgs issue or nixpkgs-update issue. I guess the automation could soft reset the git state back to what it started with and then perform a commit of its own, but this sounds a little hacky. On the other hand nixpkgs could simply state that update scripts should not be allowed to perform git operations on the repository by default and then things would just work on r-ryantm side. There's probably other solutions may exist as well, but this is just to illustrate my point that it's not clear to me what's the next step from here. | 21:45:10 | |
19 Apr 2025 | ||
12:59:35 | ||
21 Apr 2025 | ||
10:54:13 |