| 24 Oct 2025 |
 emily | funny header name: SecProtocolRestrictedOptionsGoAwayIfNotApprovedForEPSKsPriv.h | 01:45:28 |
 samasaur | any idea why qt can't find Network.framework | 01:47:16 |
| emily | uhh | 01:48:19 |
| emily | did it -framework it? | 01:48:21 |
| samasaur | https://github.com/qt/qtbase/blob/e902f8ad85a3a36b266f5e96bf3dc1ddad9fa18e/cmake/QtFrameworkHelpers.cmake#L42 | 01:48:34 |
| samasaur | can't find it at configure time, not build time | 01:48:45 |
| emily | have you looked at our Qt patches | 01:49:31 |
| samasaur | oh dear | 01:49:42 |
| samasaur | no | 01:49:43 |
| emily | they're not as bad as they used to be | 01:49:58 |
| emily | find_library(${cache_var_name} "${framework_name}")
if(${cache_var_name} AND ${cache_var_name} MATCHES ".framework$")
set(${out_var} "-framework ${framework_name}" PARENT_SCOPE)
else()
set(${out_var} "${out_var}-NOTFOUND" PARENT_SCOPE)
endif()
| 01:50:09 |
| emily | hmm I hope I didn't break CMake's ability to find frameworks | 01:50:14 |
| samasaur | so the thing that's odd is that it appears able to find CFNetwork but not Network | 01:51:07 |
| samasaur | despite everything appearing to be "found" the same way | 01:51:15 |
 Randy Eckenrode | It would probably be worth making the symbols always be available for libpcap and libffi, but most things that want to use them will redeclare them anyway. | 01:51:29 |
| emily | libpcap and libffi will already get them always available | 01:51:43 |
| emily | because the public SDK causes SPI_AVAILABLE(…) to expand to nothing | 01:51:51 |
| emily | correctly in this case | 01:51:56 |
| emily | the only time we ever don't want that behaviour is basically when we're hacking up xnu headers, I think | 01:52:39 |
| Randy Eckenrode | I don’t know that the private headers with those declarations are even included in the packages. We build both with their configure scripts. | 01:52:42 |
| emily | which is why I suggested the best approach is probably to replace SPI_ → API_ in xnu headers and have an empty AvailabilityInternalPrivate.h (or drop their includes of it) | 01:53:12 |
| emily | since that will ensure the right behaviour there without screwing up the more common uses of SPI_* in the source releases | 01:53:28 |
| emily | (where we do want them to be elided) | 01:53:33 |
| Randy Eckenrode | We shouldn’t be hacking up xnu headers. We should actually be building them because that sucks a lot less than what we are currently doing. | 01:53:35 |
| emily | define "actually building them"? | 01:54:17 |
| emily | I don't think we can avoid modifying them in some way | 01:54:36 |
| Randy Eckenrode | The xnu makefiles have a target for building the headers. | 01:54:37 |
| emily | fundamentally we are not actually running our own XNU at runtime | 01:54:46 |
| Randy Eckenrode | The old source releases used to do it, but they made a mess pf the result. | 01:55:06 |
| Randy Eckenrode | * | 01:55:13 |
