In reply to @emilazy:matrix.org
hey I like True Tone

ICU tests fail on x86_64-darwin. ☹️

Triggered by Thread: 0

Exception Type:    EXC_ARITHMETIC (SIGFPE)
Exception Codes:   0x0000000000000001, 0x0000000000000000

Termination Reason:  Namespace SIGNAL, Code 8, Floating point exception: 8
Terminating Process: exc handler [89045]


Thread 0 Crashed:
0   libicui18n.76.1.dylib         	       0x10e162427 icu::Calendar::roll(UCalendarDateFields, int, UErrorCode&) + 1735
1   intltest                      	       0x10465c2f5 CalendarTest::Test22633RollTwiceGetTimeOverflow()::$_0::__invoke(icu::Calendar*, UCalendarDateFields) + 69
2   intltest                      	       0x10465bd35 CalendarTest::RunTestOnCalendars(void (*)(icu::Calendar*, UCalendarDateFields)) + 565
3   intltest                      	       0x1046e271c IntlTest::runTestLoop(char*, char*, char*) + 492
4   intltest                      	       0x1046e2320 IntlTest::runTest(char*, char*, char*) + 128
5   intltest                      	       0x1046e2152 IntlTest::callTest(IntlTest&, char*) + 82
6   intltest                      	       0x1046eee00 IntlTestFormat::runIndexedTest(int, signed char, char const*&, char*) + 4016
7   intltest                      	       0x1046e271c IntlTest::runTestLoop(char*, char*, char*) + 492
8   intltest                      	       0x1046e2320 IntlTest::runTest(char*, char*, char*) + 128
9   intltest                      	       0x1046e2152 IntlTest::callTest(IntlTest&, char*) + 82
10  intltest                      	       0x1046f16ed MajorTestLevel::runIndexedTest(int, signed char, char const*&, char*) + 461
11  intltest                      	       0x1046e271c IntlTest::runTestLoop(char*, char*, char*) + 492
12  intltest                      	       0x1046e2320 IntlTest::runTest(char*, char*, char*) + 128
13  intltest                      	       0x1046e5360 main + 3568
14  dyld                          	       0x2050c5781 start + 3457

Hello folks, I want to PR darwin support for libtree (analysis of linked libraries) and I have questions about tests.

There's a passthru.tests attrset at https://github.com/NixOS/nixpkgs/blob/5e2a59a5b1a82f89f2c7e598302a9cacebb72a67/pkgs/by-name/li/libtree/package.nix#L28-L46 which tests ls from coreutils. On macos, by default, it checks the macOS build of ls, which is not an ELF. I can get it to work properly using pkgsCross, as in the following.

    (libtree.override {
      inherit (pkgsCross.aarch64-multiplatform) coreutils;
    }).overrideAttrs
      (old: {
        meta = lib.recursiveUpdate (old.meta or { }) { platforms = lib.platforms.darwin; };
      })

I presume that in this case libtree should always test the pkgsCross coreutils… but certainly the tests fail on macos without it. What's the idiomatic way of handling this case?

Hello folks, I want to PR darwin support for libtree (analysis of linked libraries) and I have questions about tests.

There's a passthru.tests attrset at https://github.com/NixOS/nixpkgs/blob/5e2a59a5b1a82f89f2c7e598302a9cacebb72a67/pkgs/by-name/li/libtree/package.nix#L28-L46 which tests ls from coreutils. On macos, by default, it checks the macOS build of ls, which is not an ELF. I can get it to work properly using pkgsCross, as in the following.

    (libtree.override {
      inherit (pkgsCross.aarch64-multiplatform) coreutils;
    }).overrideAttrs
      (old: {
        meta = lib.recursiveUpdate (old.meta or { }) { platforms = lib.platforms.darwin; };
      })

I presume that in this case libtree should always test the pkgsCross coreutils… but certainly the tests fail on macos without it. What's the idiomatic way of handling this case?

[Edit: I don't mean idiomatic way of implementing the changes, as opposed to the override, I mean the idiomatic way of handling the cross-platform dependency in the tests.]