| 25 Oct 2025 |
K900 | Pretty sure that policy doesn't even EXIST anymore | 07:33:36 |
K900 | https://gitlab.kitware.com/cmake/cmake/-/blob/master/Help/policy/CMP0025.rst | 07:34:27 |
K900 | Yep removed in 4.0 | 07:34:30 |
samasaur | oh cool | 07:34:40 |
samasaur | okay let me cancel this build and start a new one with that line gone too | 07:34:51 |
samasaur | and then i'm gonna go to sleep and we will see what i come back to in the morning | 07:35:05 |
Randy Eckenrode | Could they be referring to other packages’ frameworks? | 10:36:42 |
Randy Eckenrode | Though if we don’t package them, why prefer the non-framework when that’s all you’ll find anyway …. | 10:36:50 |
Randy Eckenrode | e.g., https://github.com/NixOS/nixpkgs/pull/447351 | 10:41:34 |
emily | destroy it | 12:43:00 |
samasaur | build successful 🎉 | 17:51:31 |
samasaur | https://github.com/NixOS/nixpkgs/pull/455592 | 17:51:33 |
emily | K900: (we need a freeze exemption from the RMs to merge that) | 18:08:09 |
emily | (though I support it) | 18:08:14 |
K900 | Uhh | 18:08:38 |
K900 | No we don't? | 18:08:44 |
K900 | I guess technically this could be considered breaking behavior | 18:08:54 |
K900 | But come on | 18:08:57 |
emily | it's a breaking change when there's both a framework and a library with the same name | 18:09:37 |
emily | which is exactly what Qt is unhappy about | 18:09:42 |
emily | but I suppose there may not be many other examples than libnetwork/Network | 18:10:16 |
emily | I'm not totally confident this isn't going to blow some things up on staging though | 18:18:07 |
emily | but hopefully it will be manageable if it does | 18:18:20 |
samasaur | out of the list that qt uses (AppKit, CFNetwork, AssetsLibrary, Photos, AudioToolbox, ApplicationServices, Carbon, CoreFoundation, CoreServices, CoreGraphics, CoreText, CoreVideo, CryptoTok enKit, DiskArbitration, Foundation, IOBluetooth, IOKit, IOSurface, ImageIO, Metal, MobileCoreServices, QuartzCore, Security, SystemConfiguration, UIKit, CoreL ocation, CoreMotion, WatchKit, GameController, CoreBluetooth, AVFoundation, Photos, Contacts, EventKit, HealthKit, UniformTypeIdentifiers, Network, OpenGL), Network was the only example of a conflict | 18:19:54 |
samasaur | so i think it's only likely to cause problems if anything wants libnetwork.tbd or some third-party conflicting name | 18:20:25 |
samasaur | and it should be fixable with -DCMAKE_FIND_FRAMEWORK=LAST in cmakeFlags | 18:20:47 |
emily | I wonder what libnetwork.tbd is for | 18:21:41 |
samasaur | but yeah it is a breaking change. hopefully just theoretically and not in practice | 18:22:06 |
samasaur | --- !tapi-tbd
tbd-version: 4
targets: [ x86_64-macos, x86_64-maccatalyst, arm64-macos, arm64-maccatalyst,
arm64e-macos, arm64e-maccatalyst ]
install-name: '/usr/lib/libnetwork.dylib'
reexported-libraries:
- targets: [ x86_64-macos, x86_64-maccatalyst, arm64-macos, arm64-maccatalyst,
arm64e-macos, arm64e-maccatalyst ]
libraries: [ '/System/Library/Frameworks/Network.framework/Versions/A/Network' ]
...
| 18:22:58 |
samasaur | i don't really know how to read these but it looks like it just reexports Network.framework? | 18:23:14 |