| 26 Oct 2025 |
prince213 | Nice to see a shorter patch to this | 07:05:12 |
prince213 | I'd suggest that we target this to master, and add a comment to remove this line when 455592 reaches master | 07:05:53 |
samasaur | yeah the patch way was overkill | 07:05:53 |
samasaur | i had found something similar upstream when i was trying to solve the issue and i got in my own head about it | 07:06:14 |
samasaur | this also has the benefit of being a) the right solution; b) essentially exactly the same thing as the CMake setup hook PR that went to stagign | 07:06:46 |
samasaur | * this also has the benefit of being a) the right solution; b) essentially exactly the same thing as the CMake setup hook PR that went to staging | 07:06:47 |
samasaur | huh okay apparently if you force-push to a closed PR on github you can no longer reopen it | 07:07:41 |
prince213 | Time to start a new one I guess | 07:08:10 |
samasaur | i guess so | 07:08:15 |
samasaur | wait a second, maybe if i force-push back to what it was i can reopen it and then force-push again | 07:08:29 |
prince213 | Ah try it | 07:08:39 |
prince213 | Maybe you can only reopen if its HEAD is at the original place | 07:08:57 |
samasaur | yeah that's my theory | 07:09:10 |