| 22 Dec 2025 |
Ihar Hrachyshka | you mean fd_sets? | 17:43:04 |
Randy Eckenrode | Yeah. | 17:43:51 |
Randy Eckenrode | That comment about where the sets are allocated doesn’t make sense to me. | 17:44:42 |
Ihar Hrachyshka | guess I should just test and see. I have a reproducer, just need to recompile glib to qemu and see. | 17:44:57 |
Randy Eckenrode | * | 17:44:59 |
Ihar Hrachyshka | source == hacker news nobody | 17:45:27 |
Randy Eckenrode | https://github.com/apple-oss-distributions/xnu/blob/f6217f891ac0bb64f3d375211650a4c1ff8ca1ea/bsd/sys/_types/_fd_def.h#L52_L54 | 17:46:06 |
Randy Eckenrode | Fish shell developer? | 17:47:01 |
Ihar Hrachyshka | I was actually also looking at the same struct def. so looks like we may need to also define the __DARWIN_FD_SETSIZE otherwise we write past the end of the struct (I think) | 17:47:57 |
Randy Eckenrode | Or malloc it based on the size of the incoming set. | 17:49:12 |
Randy Eckenrode | Glib supports using cleanup functions to make that less messy. | 17:49:27 |
Randy Eckenrode | Though if it’s a mask for all fds, you don’t really know the needed size. | 17:50:00 |
Randy Eckenrode | https://man.freebsd.org/cgi/man.cgi?select | 17:52:21 |
Randy Eckenrode | Apple mentioned FreeBSD being unlimited. I agree we should probably increase the amount of memory it’s using (either by defining FD_SETSIZE or some other way). | 17:53:19 |