| 17 May 2024 |
 jade_ | that's pretty cool that it does that | 00:56:35 |
 Qyriad | In reply to@strawberry:puppygock.gay
does no one amend or.. well no because amending makes understanding the history of a PR harder! | 00:56:46 |
| Qyriad | and this is why people these days just fucking squash everything | 00:56:57 |
| jade_ | yeah like, the fundamental way that gh pr reviews work is broken | 00:57:09 |
 strawberry🍓 (it/pup/she/they) 🏳️⚧️ 💜 🦴 (puppygock.gay) | yeah but like, i dont get why amending a 2 line diff from a review is bad | 00:57:11 |
| strawberry🍓 (it/pup/she/they) 🏳️⚧️ 💜 🦴 (puppygock.gay) | if it's big yes make it a separate commit | 00:57:21 |
| Qyriad | it's not, really, but no one cares about commit history because of this whole cycle | 00:57:30 |
| jade_ | In reply to @strawberry:puppygock.gay
yeah but like, i dont get why amending a 2 line diff from a review is bad oh, another thing that gerrit Fixes is that it has a way better online editor to Just Fix someone's change as a reviewer if you want to submit it with changes. github doesn't let you stage multiple things together into one commit amend, or even let you make a commit amend from web. | 00:58:20 |
| strawberry🍓 (it/pup/she/they) 🏳️⚧️ 💜 🦴 (puppygock.gay) | i tried once fixing someone's PR from github UI, and i never ever want to do it again | 00:58:44 |
| strawberry🍓 (it/pup/she/they) 🏳️⚧️ 💜 🦴 (puppygock.gay) | * i tried once fixing someone's PR from github UI (literally something so small), and i never ever want to do it again | 00:58:57 |
| jade_ | overall this reduces review latency massively because reviewers can just fix their minor complaints like typos or whatever without taking another cycle | 00:58:59 |
| strawberry🍓 (it/pup/she/they) 🏳️⚧️ 💜 🦴 (puppygock.gay) | sometimes i'd rather just merge it and do the 2 line fix myself | 00:59:51 |
| strawberry🍓 (it/pup/she/they) 🏳️⚧️ 💜 🦴 (puppygock.gay) | * sometimes i'd rather just merge it and do the 2 line fix myself (on github) | 01:00:00 |
| Qyriad | yeah people don't do that nearly enough | 01:01:24 |
 julia | In reply to @jade_:matrix.org
overall this reduces review latency massively because reviewers can just fix their minor complaints like typos or whatever without taking another cycle meanwhile rust ppl, complaining about how github's pr review workflow thingy sucks lol | 01:08:42 |
| jade_ | In reply to @strawberry:puppygock.gay
i tried once fixing someone's PR from github UI (literally something so small), and i never ever want to do it again for what its worth, it's probably less fucked if you use . to open codespaces, but i have never actually tried that | 01:08:44 |
| strawberry🍓 (it/pup/she/they) 🏳️⚧️ 💜 🦴 (puppygock.gay) | In reply to @jade_:matrix.org
for what its worth, it's probably less fucked if you use . to open codespaces, but i have never actually tried that i didnt actually know you can edit PRs through web vscode | 01:09:15 |
| julia | I uh might but high but where is the submit button on gerrit | 01:09:24 |
| Qyriad | Screenshot? | 01:09:30 |
| jade_ | In reply to @julia:the-apothecary.club
meanwhile rust ppl, complaining about how github's pr review workflow thingy sucks lol rust ppl even have a nice gh review process as far as gh review processes go, they have bors so they can merge-queue things, have good reviewer assignment, bors d+ to delegate merging to the author after they fix something minor, and more | 01:09:40 |
| julia | 
Download image.png | 01:09:50 |
| jade_ | In reply to @julia:the-apothecary.club
sent an image. top right | 01:09:56 |
| Qyriad | Right side of the screen | 01:09:57 |
| julia | ... i refreshed the page and it appeared | 01:10:14 |
| julia | thanks | 01:10:16 |
| Qyriad | In reply to@jade_:matrix.org
rust ppl even have a nice gh review process as far as gh review processes go, they have bors so they can merge-queue things, have good reviewer assignment, bors d+ to delegate merging to the author after they fix something minor, and more (And look how much work they had to reinvent to make Github review even bearable) | 01:10:16 |
| jade_ | that's correct | 01:10:21 |
| Qyriad | Oh yeah Gerrit needs to be refreshed to update basically anything correctly. It sucks | 01:10:30 |
| jade_ | i think it's to workaround the big gerrit instances being slow | 01:10:44 |
| jade_ | ours is fast as fuck though because it is not big | 01:10:50 |
