| 30 May 2024 |
delroth | also lost the code-review: +2 in the process though | 14:06:26 |
raitobezarius (DECT: 7248) | thanks, it came back | 14:06:59 |
raitobezarius (DECT: 7248) | i didn't find an easy way to look up a buildbot id number from the CL number | 14:07:47 |
jade_ | https://gerrit.lix.systems/c/lix/+/1356 there's another 20% off the build time | 20:58:03 |
jade_ | real deep discount on build times as of late | 20:58:37 |
jade_ | i think that if we managed to move all the json stuff into one staticlib or something then unity-built it, we could probably save about 40% of build time. like. i see about 400s on-cpu instantiating nlohmann stuff, but it may be that those are not actually additive and it's actually 200s. either way. our json parsing is expensive | 21:10:44 |
jade_ |  Download image.png | 21:13:05 |
Qyriad | In reply to@delroth:delroth.net someone can maybe retrigger CI - I don't have perms to do so :) you're supposed to | 23:13:17 |
Qyriad | lemme fix that | 23:13:28 |
Qyriad | you may have to log out and log back in, but you should have those permissions now | 23:14:30 |
Qyriad | In reply to@jade_:matrix.org i think that if we managed to move all the json stuff into one staticlib or something then unity-built it, we could probably save about 40% of build time. like. i see about 400s on-cpu instantiating nlohmann stuff, but it may be that those are not actually additive and it's actually 200s. either way. our json parsing is expensive we could also switch away from nlohmann and probably gain some runtime JSON performance too | 23:14:52 |
| 31 May 2024 |
julia | Qyriad: just acked some of the comments with cl/1160 & cl/1161 and removed some code TODOs, since you just rebased them, if build suceeds is OK to merge them...? | 13:06:50 |
julia | although I suppose you probably need to do a code review+2 again | 13:06:59 |
julia | * although I suppose you probably need to do a code review approval again. still not quite used to how gerrit does this / when ok to actualy merge 🙃 | 13:07:20 |
Qyriad | If the submission button is there, you can merge | 13:11:21 |
julia | yea ol | 13:13:05 |
julia | * oki! | 13:13:16 |
| Ambroisie joined the room. | 13:16:48 |
julia | welp, nevermind, apparently all the parents in the relation chain have to be done first. which... makes sense, I guess. lol. (i was kinda just amending each individually, though, so 🤷, that relation might be kinda broken now
| 13:23:14 |
Ambroisie | Yeah, Gerrit is quite naive in its handling of stacked patches
You have to explicitly un-parent independent commits to not have parent-child relationships if you want to be able to merge them out of order | 13:25:24 |
Qyriad | which you can do with the rebase button, to be clear, but it won't do it automatically | 14:16:46 |
aprl (GPN; DECT 2774; SIP GAYS) | hey is there a Lix compile guide somewhere? (we wanna compile it for riscv rn) | 14:31:42 |
toinux | is MakeFile an accepted answer ? | 15:01:00 |
toinux | * is "meson.build" an accepted answer ? | 15:01:49 |
toinux | https://git.lix.systems/lix-project/lix/src/branch/main/doc/manual/src/contributing/hacking.md
everything is detailed here, I was able to create a FreeBSD port by inspiring myself with the following informations | 15:02:17 |
toinux | btw, is someone willing to implement lix-doc in meson so we can build everything without depending on Nix ?
I already made a quickpatch in FreeBSD ports, but I think something more official would be better | 15:03:12 |
toinux | * btw, is someone willing to implement lix-doc in meson so we can build everything without depending on Nix ?
I already made a quickpatch in FreeBSD ports, but I think something more official (and present in upstream) would be better | 15:03:28 |
delroth | https://git.lix.systems/lix-project/lix/issues/256 | 15:05:09 |
toinux | here is my crappy solution | 15:06:05 |
toinux | https://github.com/KittenConnect/lix-bsd-port/commit/e9e0861287ebde5b6e7e3ec63b4d36fa74aaa0c1#diff-ff0b79bff742384fb63d206b8c1687f671257abbe5e966d007e5df56283d8f46R9 | 15:06:26 |