| 18 May 2024 |
 julia | actually that seems to be checking for the thing with "backward" compat on the daemon side | 04:16:32 |
| julia | 
Download image.png | 04:17:10 |
| julia | (i was looking to see if had more info than just valid for remote store) | 04:17:25 |
| julia | * (i was looking to see if had more info than just valid for remote store, i think the answer is no) | 04:18:23 |
| julia | 
Download image.png | 04:25:08 |
| julia | uh so why is this trying to copy my version of the nixpkgs source to the remote store | 04:25:20 |
| julia | * uh so why is this trying to copy my version of the nixpkgs source to the remote store... and then eventually failing with 413 | 04:25:30 |
 Lunaphied | In reply to @jade_:matrix.org
https://git.lix.systems/lix-project/lix/src/commit/7a3745b07607d3fc85fb5a0a08832ab078080884/src/libstore/remote-store.cc#L313-L315 Aaaaa jade why would you do this now I've seen how bad the protocol serializing code is again | 04:45:52 |
| Lunaphied | (Seriously the fact Nix works at all is remarkable in the face of that code) | 04:47:58 |
| julia | I keep running into FIXME: concerning statement | 04:49:33 |
| julia | screams queryPathInfoUncached (virtual method on a base class) in some implementations returns nullptr for "not there" and others throws an error | 04:56:15 |
| julia | ... some of them even shell out to other functions and catch their invalid path errors | 04:58:35 |
| julia | * ... some of them even shell out to other functions and catch their invalid path errors so as to return nullptr | 04:58:50 |
 Qyriad | yeah. we have inherited a codebase from hell xP | 04:59:35 |
| julia | most seem to be returning nullptr... should I standardise on that? | 04:59:53 |
| Qyriad | absolutely, just carefully make sure the result behavior is still the same, and try to keep changes in a CL closely related | 05:01:50 |
| Qyriad | but we would absolutely love this fixed | 05:01:56 |
| julia | yep planning | 05:02:05 |
| Qyriad | it's minor but every bit helps in this codebase | 05:02:11 |
| julia | it's a protected API so shouldn't have many consumers anyway | 05:02:18 |
| julia | * it's a protected method so shouldn't have many consumers anyway | 05:02:28 |
| julia | it has exactly (1) consumer | 05:06:07 |
| julia | which immediately throws an error anyway | 05:06:32 |
| julia | * which does some more stuff then throws an error anyway | 05:06:45 |
|  madjar joined the room. | 06:49:16 |
 jade_ | In reply to @qyriad:katesiria.org
yeah. we have inherited a codebase from hell xP hellco | 09:38:58 |
|  draupnirchanged room power levels. | 09:42:48 |
| julia | this is certainly a code base | 09:46:16 |
| julia | me, last hour or so: "what's the point of requireValidPath?"
the code: never uses it
the one doc comment: "If requireValidPath is set to true (the default), the path must be inside a valid store path, otherwise it just needs to be physically present (but not necessarily properly registered)" (for "read a file to a string"). ???? | 09:48:13 |
| julia | * me, last hour or so: "what's the point of requireValidPath?"
the code: never uses it
the one doc comment: "If requireValidPath is set to true (the default), the path must be inside a valid store path, otherwise it just needs to be physically present (but not necessarily properly registered)" (for "read a file to a string"). ????
so there's this one argument passed through n levels of depth through libstore whose entire purpose appears to be... for when the store is borked | 09:48:56 |
