13 Sep 2025 |
emily | it seems like it's no longer necessary on 25.11 at least. | 05:19:57 |
aloisw | How are you building? | 05:19:57 |
emily | with LLVM 21. | 05:20:04 |
emily | and a bunch of other things | 05:20:07 |
emily | er, CMake 4 in particular | 05:20:28 |
emily | I forgot it was a CMake 4 thing and not an LLVM 21 thing. | 05:20:34 |
aloisw | No I mean how exactly you are consuming the package. If you just callPackage the package.nix then it indeed won't use the custom capnproto. | 05:20:47 |
emily | oh. yes, I am in fact doing that right now, for reasons | 05:21:24 |
emily | okay so yeah it should be made conditional | 05:21:38 |
emily | unless there is a strong feeling about keeping it at an old version, but like⦠there's nothing there that's not upstream. and the old version is also about to break | 05:22:00 |
aloisw | The nodiscard change is not in nixpkgs btw, so the overridden version needs to be kept for that. | 05:22:53 |
aloisw | I can look into updating it. | 05:23:01 |
emily | hmm I think that wasn't there when I was looking at 2.93 :) | 05:24:18 |
emily | we could just patch that in Nixpkgs, though? | 05:24:45 |
emily | oh I guess it's breaking-ish | 05:24:53 |
emily | sure then | 05:24:57 |
K900 | Uhh is Lix on unstable also broken now | 15:33:45 |
emily | are you running into the CMake 4 thing | 15:45:57 |
K900 | No | 15:48:59 |
K900 | toml11 | 15:49:02 |
K900 | Wait no | 15:49:05 |
K900 | Lowdown | 15:49:07 |
K900 | I think | 15:49:08 |
ghpzin | https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.lix.x86_64-linux https://hydra.nixos.org/build/307566238
lix/libcmd/liblixcmd.so.p/markdown.cc.o -c ../lix/libcmd/markdown.cc
../lix/libcmd/markdown.cc:18:10: error: field designator 'cols' does not refer to any field in type 'struct lowdown_opts'
18 | .cols = (size_t) std::max(windowWidth - 5, 60),
| ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lix/libcmd/markdown.cc:19:10: error: field designator 'hmargin' does not refer to any field in type 'struct lowdown_opts'
19 | .hmargin = 0,
| ~^~~~~~~~~~~
../lix/libcmd/markdown.cc:20:10: error: field designator 'vmargin' does not refer to any field in type 'struct lowdown_opts'
20 | .vmargin = 0,
| ~^~~~~~~~~~~
3 errors generated.
| 15:49:49 |
raitobezarius | https://github.com/NixOS/nixpkgs/pull/442624/files | 16:18:40 |
raitobezarius | * https://github.com/NixOS/nixpkgs/pull/442624 FYI | 16:18:43 |
Marie | Am I supposed to do the gerrit suggest owners thing and add reviewers?
Or just be patient and wait for someone to look at it? | 17:34:18 |
raitobezarius | Yes, you need to use code owners | 19:52:27 |
Marie | oh, okay
It lists 3 people as code owners for my CL on release-2.93, but it doesn't list anyone on the one for main | 20:28:10 |
raitobezarius | Hm surprising | 21:44:01 |