| 16 May 2024 |
|  zrsk joined the room. | 13:54:49 |
 samrose | In reply to @lunaphied:lunaphied.me
I think there were a few CLs on the Gerrit but nothing being actively worked The other thing that I could do if it helps is test things and try to find bugs. I did do some C++ work in the past, but may lack the time to do it justice here at least for about 30 days or so | 15:55:29 |
 Qyriad | we are not in any rush 🙂 | 17:20:53 |
| samrose | Would it help to also test out the existing Lix code and try to find issues/bugs etc? | 17:23:21 |
| Qyriad | absolutely | 17:23:41 |
| samrose |
- how do people feel about the existing test suite that comes along with nix source code or Lix?
| 17:23:48 |
| Qyriad | it's pitiful | 17:24:10 |
| samrose | heh | 17:24:16 |
 raitobezarius | expanding it is cool | 17:24:23 |
| raitobezarius | writing new tests for builtins which are not tested | 17:24:30 |
| raitobezarius | new test behaviors, etc. | 17:24:32 |
| Qyriad | we have three flavors of test:
gtest (offer only available in libexpr and libutil) bash script virtual machine
the vast, vast majority of testing is in the "bash script" flavor and it is a mess | 17:25:01 |
| samrose | I was just going to ask on the "functional" tests: do we still like using bash there? | 17:25:56 |
| samrose | the last time that I worked on a major nix related cli project that used bash, or bats for testing, over time it became rather kind of hard to maintain | 17:26:42 |
| samrose | I am not usually a big python fan, but in that project we heard from some in the Rust community that they actually use Python to test CLI and seem to have success there. | 17:27:59 |
| Qyriad | no gods please kill bash testing. the problem is that it's kind of really difficult to migrate an entire test suite and be sure that you actually migrated the test suite correctly and won't lose coverage accidentally in the process, which makes any kind of migration a bit nerve wracking | 17:28:36 |
| samrose | yes it's a rather large undertaking | 17:28:52 |
| samrose | could be done in chunks | 17:28:59 |
| Qyriad | at the very least though, it would be wonderful to have an option for new tests to not just be a mess of bash | 17:29:17 |
| samrose | yes it could be to choose a new approach that this community is truly happy with, rewrite some of the old tests, use it for all new, and then over time rewrite all old | 17:30:00 |
| Qyriad | yeah | 17:30:31 |
| samrose | and also probably you all would want to speak into the testing paradigm to make sure the tests are relevant | 17:30:52 |
| Qyriad | mhmm | 17:33:22 |
| Qyriad | In reply to@samrose:matrix.org
I am not usually a big python fan, but in that project we heard from some in the Rust community that they actually use Python to test CLI and seem to have success there. Python's fine, and it's already part of the buildsystem in other ways. If there's something that's a better idea or more preferred for another reason we can talk about that too | 17:35:04 |
| samrose | In reply to @qyriad:katesiria.org
Python's fine, and it's already part of the buildsystem in other ways. If there's something that's a better idea or more preferred for another reason we can talk about that too It would be nice if someone had written a general cli testing suit in Rust, or Go (which likely would make the test suite run faster) but I am not aware of anything that exists. I think the Rust cli tool community gravitated toward using python due to Pexpect, and a lot of existing tools that are good fit for test suite. | 17:37:19 |
| samrose | (it seems like functional tests need the most help basically if I am not mistaken. Apologies if you basically already said this) | 17:38:19 |
| Qyriad | no they definitely do. those are the "bash" flavor of tests | 17:38:40 |
| samrose | https://git.lix.systems/lix-project/lix/src/branch/main/tests/functional | 17:38:51 |
| Qyriad | yep | 17:38:57 |
| Qyriad | something that probably could be migrated separately is the stuff that sets up the daemon the test suite uses | 17:39:16 |
