| 20 Oct 2024 |
 EsperLily [she/her] | * i read through that already and it talks about the mechanics of it, i just didn't know if there's any etiquette around e.g. grabbing an issue, or asking for review. that page also mentions topics but doesn't say if there's any expectation around how topics are used (edit: just read gerrit documentation on topics, sounds like something i should probably ignore) | 20:12:33 |
 just1602 | In reply to @esperlily:matrix.org
i read through that already and it talks about the mechanics of it, i just didn't know if there's any etiquette around e.g. grabbing an issue, or asking for review. that page also mentions topics but doesn't say if there's any expectation around how topics are used I only submit 2 CL and they were link to an issue, but I'm not a core dev at all, so I'll let other people answer since it's gonna be more useful to you. | 20:12:49 |
| EsperLily [she/her] | ok i went ahead and submitted the changelist | 20:16:02 |
 benjamin | In reply to@ersei:ersei.net
what do y'all think about setting IN_NIX_SHELL in nix3? it's the same behaviour as nix2 I would like this a lot as a user. Currently I'm working around the absence of an IN_NIX_SHELL-equivalent by looking for nix store paths in PATH to set my shell prompt | 21:09:24 |
| benjamin | https://github.com/NixOS/nix/issues/6677 <- issue I opened about this back in 2022 | 21:10:18 |
| EsperLily [she/her] | I have SHLVL in my prompt and that's my normal cue for being in a nix shell. Having some env var might be nice, though i'm a little concerned about reusing IN_NIX_SHELL as that currently implies a much larger change to the shell environment than just some PATH additions | 22:00:54 |
| EsperLily [she/her] | i'm looking at the auto-optimize-store darwin bug and reading through the optimize-store code i'm slightly concerned about the possibility of TOCTTOU here. Can multiple calls to LocalStore::optimisePath_ ever occur concurrently (whether it's different processes or different threads in the same process)? There's a minor TOCTTOU bug here though the conditions for triggering it are likely hard (though possibly also triggerable if a GC is occurring at the same time, i'm not sure how GC interacts with optimize store yet) | 22:45:00 |
| 21 Oct 2024 |
| benjamin | In reply to@esperlily:matrix.org
I have SHLVL in my prompt and that's my normal cue for being in a nix shell. Having some env var might be nice, though i'm a little concerned about reusing IN_NIX_SHELL as that currently implies a much larger change to the shell environment than just some PATH additions yeah, IN_NIX3_SHELL or something might be better? | 02:31:30 |
 Linux Hackerman | jade_: I applied your suggestions in https://gerrit.lix.systems/c/lix/+/2057 -- anything else to do? And is it appropriate for me to ping you here if I'm not sure about the status? :) | 11:46:08 |
 KFears (tragedy arc) | I can't figure out the "functional" tests (the ones that are a Bash script) at all. Locally, I get a failure for nix profile something. Remotely, functional-nix-shell fails (and it's the one that's actually supposed to fail). How do I actually run those tests correctly in the local environment? I really want to look at the detailed logs that CI won't show me :( | 13:28:46 |
 piegames | Direnv allow and just test functional-lang should suffice | 13:39:36 |
| KFears (tragedy arc) | I think just test functional-lang literally runs "functional-lang" test | 13:48:19 |
| KFears (tragedy arc) | And just test fails the wrong test but succeeds the one that actually fails | 13:48:49 |
| piegames | In reply to @kfears:matrix.org
I think just test functional-lang literally runs "functional-lang" test Yes, insert you test name here | 13:52:15 |
| piegames | In reply to @kfears:matrix.org
And just test fails the wrong test but succeeds the one that actually fails Try doing a clean build. Sometimes stuff is a bit impure, frustratingly | 13:52:39 |
| KFears (tragedy arc) | That seems to have helped | 13:57:27 |
| KFears (tragedy arc) | Thanks | 13:57:32 |
| KFears (tragedy arc) | Okay I'm just not sure anymore. I spent multiple hours bashing (get it?) my head against the wall only to discover that tests that I'm working with make no sense conceptually, are extremely obfuscated by Bash nonsense, and only failed because they did a ridiculous string comparison instead of executing commands. And now they should logically fail, except they pass, because I think the person who wrote the original test got lost in the Bash woods just like I did and wrote a test that does nothing | 15:20:21 |
| KFears (tragedy arc) | I think I'll try to see what's happening at tests/functional2 and what's next to make it the go-to approach because the experience I've had is maddening | 15:22:29 |
| KFears (tragedy arc) | It makes me feel like only around 25% of the tests are working to begin with, and it's horrifying | 15:25:02 |
| KFears (tragedy arc) | I think that's something that I explicitly want to prioritize getting done ASAP because holy shit. I've just been porting a small PR that looked like it would take 10 minutes to do and I've already been at it for days because those tests are so broken, they just don't work at all. I'd rather just nuke the Bash tests and say "deal with it and write Python instead", that way I wouldn't have spent days debugging Bash nonsense | 15:32:27 |
| piegames | Yeah, they are awful | 15:50:13 |
| piegames | They are on my backlog, but I wouldn't mind if somebody else came first | 15:50:51 |
| piegames | Basically I already did my nix-lang2 stuff on top of the old testing framework, so my motivation to touch the tests before that stuff gets merged is rather lowr | 15:51:41 |
| piegames | * Basically I already did my nix-lang2 stuff on top of the old testing framework, so my motivation to touch the tests before that stuff gets merged is rather low | 15:52:38 |
| KFears (tragedy arc) | Yeah, I can port the tests bit by bit | 16:25:56 |
| KFears (tragedy arc) | Really gotta wonder how CppNix hasn't completely collapsed under its weight with so much brokenness around | 16:28:39 |
 9999years | when nix says:
error: 7 dependencies of derivation '...-hls-test-utils-2.9.0.0.drv' failed to build
error: 18 dependencies of derivation '...-haskell-language-server-2.9.0.0.drv' failed to build
error: 1 dependencies of derivation '...-haskell-language-server-2.9.0.0.drv' failed to build
error: 64 dependencies of derivation '..-ghc-shell-for-foo-0-0-env.drv' failed to build
does that mean that 64+1+18+7 (transitive) dependencies of ghc-shell-for-foo have failed to build, or that 64 (transitive) dependencies of ghc-shell-for-foo have failed to build, of which 1 is from haskell-language-server, 18 are from a different haskell-language-server, 7 are from hls-test-utils, etc.?
| 18:21:26 |
| KFears (tragedy arc) | I think it's the latter? | 18:26:05 |
|  @ytg1234:matrix.org left the room. | 19:07:05 |
