| 20 Oct 2024 |
 KFears (tragedy arc) | I think there's like 0% overlap in developers there but it's still uncanny how both flakes and nix-installer have the exact same design mistake at their core | 08:42:58 |
| KFears (tragedy arc) | And from my research, there's not a single project that made this mistake, so I can almost picture Eelco ordering the people writing nix-installer to do their absolute best to couple the code with the statefile as much as they possibly can | 08:45:48 |
| KFears (tragedy arc) | But that's probably too much of a stretch | 08:45:58 |
| KFears (tragedy arc) | * And from my research, there's not a single other project that made this mistake, so I can almost picture Eelco ordering the people writing nix-installer to do their absolute best to couple the code with the statefile as much as they possibly can | 08:48:30 |
| KFears (tragedy arc) | I'll probably conclude my article about the flakes with "just use Lix" at this point | 08:48:55 |
|  ersei joined the room. | 18:04:23 |
| ersei | probably should've asked in this room before I added a changeset to gerrit... | 18:10:30 |
| ersei | but better late than never | 18:10:34 |
| ersei | what do y'all think about setting IN_NIX_SHELL in nix3? it's the same behaviour as nix2 | 18:11:01 |
| ersei | (my gerrit changeset in question: https://gerrit.lix.systems/c/lix/+/2090) | 18:12:01 |
 9999years | i'm pro-, you'll have to ask the girlies who care more about back-compat than me tho haha | 18:26:47 |
| 9999years | i thought nix develop set some environment variable | 18:27:02 |
| 9999years | also you should look up the --impure option instead of setting impure unconditionally probably, but maybe wait to see if people are like We Cannot Do THis first | 18:28:08 |
| ersei | In reply to @9999years:matrix.org
i thought nix develop set some environment variable it sets some nix variables, but nothing that's really meant to be detected like what I'm trying to do | 18:29:35 |
 aloisw | Well nix develop does set IN_NIX_SHELL. | 18:30:14 |
| aloisw | The problem is exactly that the closer thing to nix-shell is actually nix develop. | 18:30:40 |
| ersei | In reply to @aloisw:kde.org
Well nix develop does set IN_NIX_SHELL. but nix shell doesn't, unfortunately | 18:32:36 |
| ersei | In reply to @9999years:matrix.org
also you should look up the --impure option instead of setting impure unconditionally probably, but maybe wait to see if people are like We Cannot Do THis first I think it'll always be impure, no? since the system's path will be leaking into the environment | 18:33:04 |
| ersei | even in --ignore-environment, PATH will contain /run/current-system stuff | 18:33:35 |
| ersei | but yeah it's up to the maintainers and what they think | 18:35:34 |
| ersei | personally I think that it'll make behaviour more consistent | 18:35:49 |
| ersei | and I like having my custom prompt in fish know it's in a nix3 shell | 18:36:25 |
| ersei | though if you look at the github issue linked to the PR (https://github.com/NixOS/nix/issues/3862), there is an argument to be made that nix shell does not warrant having IN_NIX_SHELL set | 18:37:39 |
| ersei | https://github.com/NixOS/nix/issues/3862#issuecomment-918926654 specifically
Yeah, I think IN_NIX_SHELL should only be set in nix develop. nix shell only adds packages to $PATH so I don't think it really matches the expectations for IN_NIX_SHELL (which is that you're in a stdenv build environment).
| 18:37:55 |
| ersei | it is worth bringing up the purity concerns with building, since if there is an inconsistency, then there could be a source of variance | 18:40:15 |
| ersei | but I'm not familiar enough with the deterministic nature of nix builds to know if this will be an issue or not | 18:41:47 |
| aloisw | None of the shells is really designed for purity (if you want that, use sandboxing), IN_NIX_SHELL also seems to be mostly for user convenience. | 19:39:52 |
 EsperLily [she/her] | hey folks, i finally dealt with work restrictions and can now do maintenance work on Lix in my spare time. I'm getting ready now to submit my first changeset for a trivial issue, never used gerrit before, is there any established etiquette to this? | 19:53:06 |
 just1602 | EsperLily [she/her]: there's this page on the lix wiki that can probably answer a couple of your questions / interrogations: https://wiki.lix.systems/books/lix-contributors/page/gerrit | 20:02:14 |
| EsperLily [she/her] | i read through that already and it talks about the mechanics of it, i just didn't know if there's any etiquette around e.g. grabbing an issue, or asking for review. that page also mentions topics but doesn't say if there's any expectation around how topics are used | 20:09:02 |
