| 1 Aug 2025 |
 raitobezarius | In reply to @emilazy:matrix.org
I am really confused as to the conflict issues that are being envisioned then. but ok. I will leave it be I double checked again and one reason that I see is that clang-format output is bad in certain (common in the Lix codebase) corner cases | 18:35:29 |
| raitobezarius | And this is reason enough to proceed blindly with a full reformat | 18:35:36 |
| raitobezarius | * And this is reason enough to not proceed blindly with a full reformat to me | 18:35:41 |
| raitobezarius | If being broken on multiple lines with their literals cut in half, call being laid out on multiple lines breaking the logical manual grouping | 18:36:08 |
| raitobezarius | We already have some nolint and I remember that we already have troubles with incremental reformatting from time to time but manageable on the scale of it | 18:37:00 |
| raitobezarius | All the nested ternaries lose a lot of their meaning | 18:37:13 |
| raitobezarius | Also, reformatting is not even nolint-preserving | 18:38:14 |
| raitobezarius | So this will cause a lot of manual churn | 18:38:17 |
| raitobezarius | Digging more is possible, but at this point, I don't see strong evidence of an easy win we could go for and one that wouldn't hamper the active team ability to authoring changes or reviewing changes | 18:40:25 |
| raitobezarius | I'm interested in jade_ opinion on this | 18:40:36 |
 Charles | (might be good to keep it to the issue comments so things don't get lost) | 18:41:23 |
| raitobezarius | (this is done) | 18:50:24 |
| raitobezarius | In reply to @raitobezarius:matrix.org
taking care of it no problem on this end | 23:39:02 |
| 2 Aug 2025 |
|  Katalin 🔪 changed their profile picture. | 00:28:02 |
| raitobezarius | emily do you have news on https://gerrit.lix.systems/c/lix/+/3848/comments/69dc917c_8507f6a7 ?
In general, how would you like us to review the chain? I feel like there's some minor points but mostly good except for the last CL where I'm not sure yet what should we do for it | 15:20:24 |
 emily | I was half-way through revising the stack and I need to fix stuff (the installCheckPhase bug was masking test failures and I broke the build rearranging things). I expect to get to finishing it off either today or tomorrow. it should be ok to review commit-by-commit and I don't think it will substantially change on my end other than fixes | 15:23:08 |
| raitobezarius | If you need me for anything, please don't hesitate | 15:23:41 |
| raitobezarius | Charles were you able to test the exp backoff for downloads CL? (no hurry) | 15:24:08 |
| emily | the bootstrap was successful and it seems to eliminate the majority of build directory references in built binaries. haven't yet got to testing Rust and there are things like Python and other parts of LLVM that hardcode random build directory paths regardless that will need fixing up. they are already non-reproducible in the presence of concurrency anyway though, I do not think further Nixpkgs fixes on that front need to block things | 15:24:29 |
| Charles | not yet, sorry, i'll try to get to it today | 15:24:30 |
| raitobezarius | In reply to @emilazy:matrix.org
the bootstrap was successful and it seems to eliminate the majority of build directory references in built binaries. haven't yet got to testing Rust and there are things like Python and other parts of LLVM that hardcode random build directory paths regardless that will need fixing up. they are already non-reproducible in the presence of concurrency anyway though, I do not think further Nixpkgs fixes on that front need to block things So you confirm this doesn't suddenly explode nixpkgs though | 15:24:54 |
| raitobezarius | which is great to hear | 15:24:56 |
| emily | especially since I don't know if they will get backported to 25.05, so just accepting that it will expose more reproducibility issues in Nixpkgs is part of the tradeoff regardless | 15:24:57 |
| emily | yes, I'm running the stack and building lots of stuff | 15:25:13 |
| emily | including https://gerrit.lix.systems/c/lix/+/3852/5 | 15:25:28 |
| raitobezarius | sandbox = true in your case right? | 15:25:36 |
| emily | I was a little nervous the ENOTSUP may not cover everything in practice but so far it seems to | 15:25:40 |
| emily | yeah | 15:25:44 |
| raitobezarius | very cool | 15:25:52 |
| raitobezarius | thank you so much for the chain! | 15:26:11 |
