| 1 Aug 2025 |
emily | I am really confused as to the conflict issues that are being envisioned then. but ok. I will leave it be | 17:12:20 |
emily | I put up https://git.lix.systems/lix-project/lix/issues/948 | 17:51:03 |
emily | to have the discussion recorded | 17:51:09 |
emily | https://gerrit.lix.systems/c/lix/+/3858 could probably use an urgent +2 btw | 17:51:14 |
Qyriad | done | 17:53:04 |
emily | ty | 17:53:19 |
emily | sorry for the regression | 17:53:22 |
Qyriad | we approved it, so we bear that responsibility too | 17:53:40 |
raitobezarius | we should rerun CI manually on d5cfc6f19c and f077a6f36e | 18:09:44 |
raitobezarius | taking care of it | 18:10:14 |
raitobezarius | In reply to @emilazy:matrix.org I am really confused as to the conflict issues that are being envisioned then. but ok. I will leave it be I double checked again and one reason that I see is that clang-format output is bad in certain (common in the Lix codebase) corner cases | 18:35:29 |
raitobezarius | And this is reason enough to proceed blindly with a full reformat | 18:35:36 |
raitobezarius | * And this is reason enough to not proceed blindly with a full reformat to me | 18:35:41 |
raitobezarius | If being broken on multiple lines with their literals cut in half, call being laid out on multiple lines breaking the logical manual grouping | 18:36:08 |
raitobezarius | We already have some nolint and I remember that we already have troubles with incremental reformatting from time to time but manageable on the scale of it | 18:37:00 |
raitobezarius | All the nested ternaries lose a lot of their meaning | 18:37:13 |
raitobezarius | Also, reformatting is not even nolint-preserving | 18:38:14 |
raitobezarius | So this will cause a lot of manual churn | 18:38:17 |
raitobezarius | Digging more is possible, but at this point, I don't see strong evidence of an easy win we could go for and one that wouldn't hamper the active team ability to authoring changes or reviewing changes | 18:40:25 |
raitobezarius | I'm interested in jade_ opinion on this | 18:40:36 |