!lymvtcwDJ7ZA9Npq:lix.systems

Lix Development

411 Members
(Technical) development of Lix, the package manager, a Nix implementation. Please be mindful of ongoing technical conversations in this channel.137 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
1 Aug 2025
@emilazy:matrix.orgemilyI am really confused as to the conflict issues that are being envisioned then. but ok. I will leave it be17:12:20
@emilazy:matrix.orgemilyI put up https://git.lix.systems/lix-project/lix/issues/94817:51:03
@emilazy:matrix.orgemilyto have the discussion recorded17:51:09
@emilazy:matrix.orgemilyhttps://gerrit.lix.systems/c/lix/+/3858 could probably use an urgent +2 btw17:51:14
@qyriad:katesiria.orgQyriad done 17:53:04
@emilazy:matrix.orgemilyty17:53:19
@emilazy:matrix.orgemilysorry for the regression17:53:22
@qyriad:katesiria.orgQyriadwe approved it, so we bear that responsibility too17:53:40
@raitobezarius:matrix.orgraitobezariuswe should rerun CI manually on d5cfc6f19c and f077a6f36e18:09:44
@raitobezarius:matrix.orgraitobezariustaking care of it18:10:14
@raitobezarius:matrix.orgraitobezarius
In reply to @emilazy:matrix.org
I am really confused as to the conflict issues that are being envisioned then. but ok. I will leave it be
I double checked again and one reason that I see is that clang-format output is bad in certain (common in the Lix codebase) corner cases
18:35:29
@raitobezarius:matrix.orgraitobezariusAnd this is reason enough to proceed blindly with a full reformat18:35:36
@raitobezarius:matrix.orgraitobezarius* And this is reason enough to not proceed blindly with a full reformat to me18:35:41
@raitobezarius:matrix.orgraitobezariusIf being broken on multiple lines with their literals cut in half, call being laid out on multiple lines breaking the logical manual grouping18:36:08
@raitobezarius:matrix.orgraitobezariusWe already have some nolint and I remember that we already have troubles with incremental reformatting from time to time but manageable on the scale of it18:37:00
@raitobezarius:matrix.orgraitobezariusAll the nested ternaries lose a lot of their meaning18:37:13
@raitobezarius:matrix.orgraitobezariusAlso, reformatting is not even nolint-preserving18:38:14
@raitobezarius:matrix.orgraitobezariusSo this will cause a lot of manual churn18:38:17
@raitobezarius:matrix.orgraitobezariusDigging more is possible, but at this point, I don't see strong evidence of an easy win we could go for and one that wouldn't hamper the active team ability to authoring changes or reviewing changes18:40:25
@raitobezarius:matrix.orgraitobezarius I'm interested in jade_ opinion on this 18:40:36

Show newer messages


Back to Room ListRoom Version: 10