| 22 Feb 2026 |
raitobezarius | (it doesn't really matter a lot in practice because we can compare patchsets) | 20:44:32 |
vczf | In reply to @raitobezarius:matrix.org vczf FYI, Gerrit etiquette is that "ack" means "you read the comment but you are not addressing it" and "done" means "you read the comment and addressed it" usually Should I have left it unresolved? Felt odd to leave it unacknowledged when it may be some time before I update the code | 22:31:15 |
| mei 🌒& changed their profile picture. | 22:54:40 |
raitobezarius | In reply to @vczf:matrix.org Should I have left it unresolved? Felt odd to leave it unacknowledged when it may be some time before I update the code Yeah it helps keep the "todo list" synced with your reviewer to leave unresolved if the code is non updated | 23:15:45 |
raitobezarius | If you ack, your reviewer is the next one who needs to act | 23:16:01 |
raitobezarius | When it should be you who should act | 23:16:14 |
vczf | Gotcha | 23:18:24 |