| 14 Aug 2025 |
emily | probably just because nobody did it? | 17:05:42 |
emily | there's already a lib.teams entry | 17:05:55 |
emily | any committer can make a GitHub team | 17:06:01 |
jade_ | wait really?? okay let's fix tha | 17:06:28 |
emily | right, it was the "just-built Lix" part | 17:06:46 |
emily | btw | 17:06:48 |
emily | you can't --accept-tests a change from an eval failure to success or vice versa | 17:06:55 |
emily | would be nice to have | 17:06:59 |
emily | https://github.com/NixOS/nix/pull/13013 | 17:15:38 |
emily | joy | 17:15:40 |
emily | does anyone else feel like backporting that so I don't spend literally all day dealing with overflow bugs :P | 17:17:40 |
jade_ | https://github.com/orgs/NixOS/teams/lix-maintainers/members done | 17:18:37 |
jade_ | woof. yeah i can do it | 17:18:55 |
emily | the src → lix rename is tremendously annoying for Nix backports because of Git's broken handling of renames. can't wait for Jujutsu's rebase algorithm to handle moves/copies. | 17:19:52 |
emily | does anyone have any tricks that they use to make it not be useless at that | 17:20:13 |
emily | I tried merge.directoryRenames | 17:20:31 |
Charles | i wonder if a similar trick for cherry-picking across formatting changes would help? | 17:21:10 |
emily | yeah, but it would require jj run rather than jj fix sadly | 17:21:43 |
emily | maybe a Git mergetool could do it but I don't feel like writing one of those | 17:21:51 |
emily | I guess I can just duplicate, move, rebase, but ugh | 17:22:01 |
Charles | 🪦 | 17:22:48 |
jade_ | yeah. idk. i find so many bugs in code review of stuff that got accepted by cppnix that i think that most code has to be rewritten anyway. i think it's possible to rename the directory in a commit that you can base the cherry-picked one on, or something like that. | 17:25:50 |
jade_ | for example, i found straight up wrong code in here (in addition to error messages that refer to concepts that only exist in C++ and not in user facing places)
i am still happy to port the fix, but it's going to experience some rewrites | 17:27:16 |
emily | I don't think your review is right | 17:28:07 |
emily | because that is a float | 17:28:12 |
emily | the whole problem is that it is going via floats, so it has float limits | 17:28:26 |
Rutile (Commentator2.0) feel free to ping | In reply to @emilazy:matrix.org you can't --accept-tests a change from an eval failure to success or vice versa You should be able to iirc, if that actually doesnt work, create an issue and ill make it work | 17:28:43 |
Rutile (Commentator2.0) feel free to ping | Oh wsit | 17:28:58 |
Rutile (Commentator2.0) feel free to ping | Yeah no | 17:29:01 |
Rutile (Commentator2.0) feel free to ping | Nvm is a different runner not just different output | 17:29:14 |