| 2 Aug 2025 |
 emily | I was a little nervous the ENOTSUP may not cover everything in practice but so far it seems to | 15:25:40 |
| emily | yeah | 15:25:44 |
 raitobezarius | very cool | 15:25:52 |
| raitobezarius | thank you so much for the chain! | 15:26:11 |
| emily | I think the fixes will not substantially change the shape of the chain, so it's probably reviewable as-is, but I believe there are still one or two review comments I did not address anyway | 15:27:32 |
| raitobezarius | I rebased it and reran CI | 15:27:52 |
| emily | I think a last-minute syntax error or something snuck in so CI results might not be that helpful past a certain point in the chain right now. I'll verify that it passes tests on Linux and Darwin and works on my machine before pushing out revisions though | 15:28:53 |
| emily | I dropped it to fix CI once it became clear I had broken that | 15:29:12 |
| raitobezarius | Okie dokie | 15:29:18 |
| raitobezarius | emily did a pass and +2ed everything I could reasonably do | 15:45:51 |
| raitobezarius | I will leave the base32 helpers to other folks | 15:45:56 |
| raitobezarius | I think I will check your chain and look if I can easily add the symlink feature | 15:46:06 |
| raitobezarius | (and also test it on Linux) | 15:46:15 |
| raitobezarius | (I will fix the compile errors locally) | 15:46:55 |
| emily | I have been testing Linux too, fwiw | 15:50:08 |
| emily | though not as extensively. there are test failures there I need to deal with | 15:50:17 |
| emily | I am increasingly of the opinion that it is unwarranted complexity. we already print out a note naming the build directory on failure | 15:50:36 |
| emily | it is just easy to miss and doesn't identify the failing derivation | 15:50:45 |
| emily | IMO making it attached to the error of the derivation failing (and therefore more prominent) would solve the UX case with fewer moving parts | 15:51:09 |
| emily | right now you get e.g.
note: keeping build directory '/nix/var/nix/b/3qxda0xkh4wllkxh182kvrza5n'
error: builder for '/nix/store/r0729886rq9nvzsngj2dnwwdl5q5dcq0-test.drv' failed with exit code 1;
last 1 log lines:
> test
For full logs, run 'nix log /nix/store/r0729886rq9nvzsngj2dnwwdl5q5dcq0-test.drv'.
| 15:51:50 |
| emily | we should simply list the retained build directory in the "For full logs" portion of the message | 15:52:00 |
| raitobezarius | what happened to my nix | 15:52:02 |
| raitobezarius | In reply to @emilazy:matrix.org
we should simply list the retained build directory in the "For full logs" portion of the message yeah you're right | 15:52:14 |
| raitobezarius | i think this is a much better idea | 15:52:17 |
| emily | (I didn't notice the note: for a long while previously before trying to test this because it doesn't even have any colour or anything) | 15:52:40 |
| emily | btw it would also be really nice if the log command was on its own line (and so the build directory too I guess), so you could more easily select the whole line and paste it | 15:53:37 |
| emily | I spend too much of my life dragging the mouse over only the right portion of the message | 15:53:57 |
| emily | something like
For full logs, run:
nix log /nix/store/r0729886rq9nvzsngj2dnwwdl5q5dcq0-test.drv
The build directory has been kept in:
/nix/var/nix/b/3qxda0xkh4wllkxh182kvrza5n
| 15:55:15 |
| emily | (or maybe even "To inspect the build directory: … cd /nix/var/nix/b/…") | 15:55:31 |
| raitobezarius | do you mind me pushing fixes to your chain? | 15:55:42 |
