| 29 Jul 2025 |
 emily | the call is inside the damn Linux conditional lol | 16:31:19 |
 raitobezarius | yes | 16:31:25 |
 WeetHet | One of them yes | 16:31:26 |
| WeetHet | There are two
| 16:31:30 |
| raitobezarius | this is why i said i know where it is ;P | 16:31:29 |
| emily | yes but the other is !useChroot | 16:31:41 |
| raitobezarius | correct | 16:31:44 |
| raitobezarius | it should be a trivial fix | 16:31:46 |
| raitobezarius | but i cannot test it automatically alas | 16:31:57 |
| emily | the call should just be moved out of the #if | 16:32:06 |
| emily | and the other one removed | 16:32:08 |
| raitobezarius | can u send a CL? | 16:32:15 |
| raitobezarius | i'm doing other things rn | 16:32:19 |
| WeetHet | Yep | 16:32:22 |
| raitobezarius | 
Download clipboard.png | 16:32:39 |
| raitobezarius | this sort of things | 16:32:41 |
| WeetHet | I need to build the devenv but then yeah | 16:33:05 |
| emily | meanwhile Sandbox: libarchive_test(91665) deny(1) file-write-create /nix/var/nix/builds/nix-build-libarchive-3.8.1.drv-6/btar.md.CvYd75 | 16:33:45 |
| emily | so much macOS fun lately | 16:34:20 |
| WeetHet | diff --git a/lix/libstore/build/local-derivation-goal.cc b/lix/libstore/build/local-derivation-goal.cc
index e0e14b09f..bc402d00a 100644
--- a/lix/libstore/build/local-derivation-goal.cc
+++ b/lix/libstore/build/local-derivation-goal.cc
@@ -1249,8 +1249,6 @@ void LocalDerivationGoal::runChild()
"non-functional."
);
}
-
- setupConfiguredCertificateAuthority();
}
for (auto & i : ss) pathsInChroot.emplace(i, i);
@@ -1406,11 +1404,8 @@ void LocalDerivationGoal::runChild()
}
#endif
- if (!useChroot) {
- /* When chroot is not used, FODs still requires a CA to be available as well. */
- if (!derivationType->isSandboxed()) {
- setupConfiguredCertificateAuthority();
- }
+ if (!derivationType->isSandboxed()) {
+ setupConfiguredCertificateAuthority();
}
if (chdir(tmpDirInSandbox.c_str()) == -1)
| 16:34:36 |
| WeetHet | I think this is the patch | 16:34:41 |
| WeetHet | Let me rebuild and check | 16:34:46 |
| emily | it looks like we were passing in the certs to non-FODs on Linux? | 16:35:24 |
| emily | so that's a fun purity bug | 16:35:37 |
| WeetHet | I think so yeah | 16:35:47 |
| WeetHet | Well it didn't even reach stable so it's all good | 16:36:02 |
| emily | btw was https://gerrit.lix.systems/c/lix/+/3765/8/lix/libstore/build/local-derivation-goal.cc#920 fixed | 16:36:02 |
| emily | because maybe want to tackle that at the same time | 16:36:07 |
| emily | no the previous logic was doing it too it looks like | 16:36:13 |
| emily | oh | 16:36:22 |
