| 18 Aug 2025 |
 raitobezarius (DECT: 7248) | In reply to @emilazy:matrix.org
I'm concerned about changing the format/prefix length twice the only change that went in afaik is the one that doesn't include derivation names in build directories | 14:50:42 |
| raitobezarius (DECT: 7248) | we can revert that one if you feel like this is not ready yet for prime time | 14:50:52 |
| raitobezarius (DECT: 7248) | and only few people would have seen it | 14:50:57 |
| raitobezarius (DECT: 7248) | i'm not sure if your concern pertains actually CLs that are still unmerged | 14:51:37 |
| raitobezarius (DECT: 7248) | or you are concerned about | 14:51:43 |
| raitobezarius (DECT: 7248) | 
Download clipboard.png | 14:51:45 |
| raitobezarius (DECT: 7248) | being merged as well | 14:51:47 |
| raitobezarius (DECT: 7248) | which seems pretty safe to me | 14:51:57 |
| raitobezarius (DECT: 7248) | either way, just please let me know what you prefer | 14:52:08 |
| raitobezarius (DECT: 7248) | we can revert the entire series if you prefer it that way as well | 14:52:15 |
| raitobezarius (DECT: 7248) | it's indeed "author-submits-the-thing" but with large stacks which receives a lot of attention and due to fast forward only, i take care of playing the merge queue until we have one | 14:52:52 |
| raitobezarius (DECT: 7248) | (if we had a merge queue, your changes would have been sent too probably because they would have been ready to submit) | 14:53:28 |
 Winter | ah, okay. maybe consider doing one, or adding the patch to the module? i imagine more ppl on unstable will start complaining 😉 | 15:05:36 |
| raitobezarius (DECT: 7248) | yep, we should do that, thanks | 15:05:58 |
 emily | this stack includes the changes that make build directories always nondeterministic on Darwin, to be clear | 15:31:39 |
| emily | it looks like the diff I had locally for that part of the stack was only cosmetic. I have been running the entire stack for a long while now and it has not caused me problems, though I have not tested the prefix you merged very extensively and it still produces rather long build directories. I was hoping to resolve the remaining questions soon and waiting on your review for the nested directory stuff | 15:32:50 |
| emily | but it should be harmless given I didn't have significant unpushed changes and the code is good | 15:33:02 |
| raitobezarius (DECT: 7248) | got it, still, I have to ask: is there any action you want to take regarding the merge? | 15:33:15 |
| emily | still some more communication would have been nice if it was urgently wanted, I was asleep for the two hours between ping and merge | 15:33:24 |
| raitobezarius (DECT: 7248) | i.e. a revert or X or Y where X or Y can be 'let's do nothing for now' :P | 15:33:26 |
| raitobezarius (DECT: 7248) | I apologize for the communication and from now on, I will communicate for your stacks | 15:33:39 |
| emily | I think let's do nothing and I will try to come back to the rest of the stack soon. but if you could finish reviewing the CL you have +1 on that would help | 15:33:48 |
| emily | since I assumed the work was blocked on that | 15:33:53 |
| raitobezarius (DECT: 7248) | (again: it was not urgently wanted but this was my Morning routineâ„¢ of merging things that are lingering) | 15:34:22 |
| emily | I expect to get back to building my system closure ~today-ish | 15:34:25 |
| raitobezarius (DECT: 7248) | alright, thanks! | 15:34:45 |
| raitobezarius (DECT: 7248) | will prioritize the last pieces | 15:34:51 |
| emily | (FWIW I think "committers always merge" or "authors always merge" is probably a better norm than it depending, for the usual Gerrit reasons of "it's obvious whose turn it is" + knowing expectations for how you should communicate if some work is pending on some testing to obtain full confidence or such) | 15:35:59 |
| emily | (though for stuff like urgent fixes or security stuff the latter can be a pain I guess) | 15:36:14 |
| emily | Nixpkgs has some problems with this too. (where two parties in a PR will deadlock waiting for the other to hit the button) | 15:36:33 |
