| 18 Dec 2025 |
helle (just a stray cat girl) | do love that the builtins fetchTarball (well, lix/libfetchers/tarball.cc technically) just forces single directory in root still, I mean fetchzip in nixpkgs specifically works around this issue it looks like, but it feels so pointless, especially as it does accept some other options and then that is hardcoded
(for tarballs this is convention, but fetchTarball due to use of libarchive will happily work on zips, isos, etc) | 11:16:01 |
helle (just a stray cat girl) | (hrm, would this be a performance and space enhancement for nixpkgs as it means they can benefit from streaming unpack that lix does?) | 11:18:01 |
helle (just a stray cat girl) | (don't know more how it is implemented under the hood, brain too frizzly to look into that) | 11:18:16 |
kloenk | I did a CL to change that a year or so ago. But it got vetoed against it | 11:22:43 |
helle (just a stray cat girl) | oh, meh | 11:23:33 |
Rutile (Commentator2.0) feel free to ping | -1 or -2? the first one is more of a "execution is meh, idea is great" and can get accepted with some rework, -2 though... | 11:24:08 |
kloenk | IIRC just a comment that someone was against it. At that time did not really had motivation for any form of discussion and basically just abandoned it | 11:25:08 |
kloenk | Will search for it later | 11:25:12 |
helle (just a stray cat girl) | I think if it is possible to do in such a way that nixpkgs can change it's definition to automatically benefit from it, without breaking cppnix compatibility (not sure if possible), it would be useful, otherwise, it's just for people like me who want to be able to do silly things without bringing in extra layers, or all of nixpkgs | 11:25:11 |
helle (just a stray cat girl) | yeah, sounds like it is probably something to bring up again | 11:25:25 |
helle (just a stray cat girl) | like I am doing silliness, but it also seems actually a thing that could work for nixpkgs and for anyone else implementing stuff outside of nixpkgs | 11:25:58 |
kloenk | was only even a slighlty hesitant. but as it was chain for the gerrit libfetcher I then did not do anything else and as nothing happened I just abandond it like half a year later https://gerrit.lix.systems/c/lix/+/1672 | 11:29:13 |
helle (just a stray cat girl) | if I have some spoons I may go over it | 11:29:37 |
kloenk | nice, not sure when I would have time to rebase it (merge conflicts and such). might try this weekend | 11:30:31 |
helle (just a stray cat girl) | it may be sensible to see if this indeed would be compatible with a nixpkgs patch though, that part I do not have the brain power for rn, that would be a direct strong reason for it | 11:31:19 |
kloenk | yeah, don't have time to look into that currently. also libfetcher is also for flake which nixpkgs could not change? | 11:32:44 |
helle (just a stray cat girl) | erm, libfetcher is all fetchers, regardless of flake or not | 11:33:04 |
kloenk | restored the CL for now, but with being afk for most of the rest of this year not sure when I can look more into it | 11:33:46 |
helle (just a stray cat girl) | yeah, I mean this may end up being well into januari can you tag me on it, so I get it in my gerrit panel | 11:34:10 |
helle (just a stray cat girl) | (can't right now quickly) | 11:34:15 |
kloenk | yeah fair. just that I back then implemented it for flakes and specificly gitiles for something that is not that much of use anymore either ways | 11:34:28 |
kloenk | done | 11:34:53 |
kloenk | sorry, had the wrong one open and noticed to late, also tagged accidentaly on the gittiles CL (which is still abadoned) | 11:35:27 |
| @e-flex:matrix.org left the room. | 11:39:14 |
helle (just a stray cat girl) | mmm, quick read via the docs,
if lib.fetchzip -> recursiveHash = true; (default) nixpkgs may be able to just shortcut to evaluating lib.fetchzip as builtins.fetchTarball { stripRoot = false; ... } unless some other special options are set (unless it supports some formats in funny ways that libarchive doesn't), but this depends on the hashes obviously ending up the same still, which I think is true | 11:47:27 |
emily | the builtins.* fetchers block eval so are not used by Nixpkgs, unless I'm misunderstanding what you mean | 11:56:50 |
helle (just a stray cat girl) | ah, okay, yeah, that is a valid reason | 11:57:11 |
helle (just a stray cat girl) | (for now) | 11:57:22 |
helle (just a stray cat girl) | (grmbls at the length of her todo list) | 11:57:36 |
helle (just a stray cat girl) | though there are still just cases where you want to not have to drag in nixpkgs to get that simple enough feature | 11:57:59 |