| 1 Aug 2025 |
 raitobezarius | I'm open to approach it with an open mind and look at it for what it is | 17:00:08 |
 emily | was that assessment made with or without knowledge of the existence of git mergetool? 😅 | 17:00:42 |
| raitobezarius | It was done with the knowlege of git mergetool | 17:00:52 |
| emily | I am really confused as to the conflict issues that are being envisioned then. but ok. I will leave it be | 17:12:20 |
| emily | I put up https://git.lix.systems/lix-project/lix/issues/948 | 17:51:03 |
| emily | to have the discussion recorded | 17:51:09 |
| emily | https://gerrit.lix.systems/c/lix/+/3858 could probably use an urgent +2 btw | 17:51:14 |
 Qyriad | done | 17:53:04 |
| emily | ty | 17:53:19 |
| emily | sorry for the regression | 17:53:22 |
| Qyriad | we approved it, so we bear that responsibility too | 17:53:40 |
| raitobezarius | we should rerun CI manually on d5cfc6f19c and f077a6f36e | 18:09:44 |
| raitobezarius | taking care of it | 18:10:14 |
| raitobezarius | In reply to @emilazy:matrix.org
I am really confused as to the conflict issues that are being envisioned then. but ok. I will leave it be I double checked again and one reason that I see is that clang-format output is bad in certain (common in the Lix codebase) corner cases | 18:35:29 |
| raitobezarius | And this is reason enough to proceed blindly with a full reformat | 18:35:36 |
| raitobezarius | * And this is reason enough to not proceed blindly with a full reformat to me | 18:35:41 |
| raitobezarius | If being broken on multiple lines with their literals cut in half, call being laid out on multiple lines breaking the logical manual grouping | 18:36:08 |
| raitobezarius | We already have some nolint and I remember that we already have troubles with incremental reformatting from time to time but manageable on the scale of it | 18:37:00 |
| raitobezarius | All the nested ternaries lose a lot of their meaning | 18:37:13 |
| raitobezarius | Also, reformatting is not even nolint-preserving | 18:38:14 |
| raitobezarius | So this will cause a lot of manual churn | 18:38:17 |
| raitobezarius | Digging more is possible, but at this point, I don't see strong evidence of an easy win we could go for and one that wouldn't hamper the active team ability to authoring changes or reviewing changes | 18:40:25 |
| raitobezarius | I'm interested in jade_ opinion on this | 18:40:36 |
 Charles | (might be good to keep it to the issue comments so things don't get lost) | 18:41:23 |
| raitobezarius | (this is done) | 18:50:24 |
| raitobezarius | In reply to @raitobezarius:matrix.org
taking care of it no problem on this end | 23:39:02 |
| 2 Aug 2025 |
|  Katalin 🔪 changed their profile picture. | 00:28:02 |
| raitobezarius | emily do you have news on https://gerrit.lix.systems/c/lix/+/3848/comments/69dc917c_8507f6a7 ?
In general, how would you like us to review the chain? I feel like there's some minor points but mostly good except for the last CL where I'm not sure yet what should we do for it | 15:20:24 |
| emily | I was half-way through revising the stack and I need to fix stuff (the installCheckPhase bug was masking test failures and I broke the build rearranging things). I expect to get to finishing it off either today or tomorrow. it should be ok to review commit-by-commit and I don't think it will substantially change on my end other than fixes | 15:23:08 |
| raitobezarius | If you need me for anything, please don't hesitate | 15:23:41 |
