| 31 Jul 2025 |
emily | is there a reason to have codeowner request as an explicit step rather than automatic? | 22:37:51 |
emily | aside from whether the step is CL or stack at once | 22:38:00 |
raitobezarius | i am confused because I'm almost certain there must be an automatic thing | 22:38:32 |
raitobezarius | but maybe Google has a secret plugin | 22:38:41 |
| 1 Aug 2025 |
K900 | @raitobezarius any reason I'm r?'d on those two changes | 04:53:32 |
raitobezarius | In reply to @k900:0upti.me @raitobezarius any reason I'm r?'d on those two changes because you are code owner and the plugin distribute load :P | 13:08:43 |
WeetHet | Is clang-format not enforced? I have format-on-save on and have run into code changing multiple times by now | 13:18:50 |
WeetHet | Could we just pull the plug and reformat the whole database? | 13:19:05 |
piegames | That would make cross-porting patches impossible, unfortunately | 13:33:54 |
WeetHet | In reply to @piegames:flausch.social That would make cross-porting patches impossible, unfortunately Aren't there tools for ast-based merging? | 13:34:47 |
WeetHet | https://mergiraf.org/ | 13:35:02 |
piegames | I've tried out Mergiraf when it was fresh, and I'd say that it's not ready yet | 13:35:33 |
WeetHet | I have it set as my merge tool, it seems okay | 13:36:09 |
raitobezarius | In reply to @weethet:catgirl.cloud Could we just pull the plug and reformat the whole database? Nope | 13:47:20 |
raitobezarius | In reply to @weethet:catgirl.cloud Is clang-format not enforced? I have format-on-save on and have run into code changing multiple times by now You should consider using *git-*clang-format | 13:47:40 |
WeetHet | Wouldn't I end up with the code that doesn't match the code style of the rest of the database? | 13:49:57 |
WeetHet | Which is even worse | 13:50:07 |
raitobezarius | No, the goal is to have progressive reformatting of the codebase | 13:50:34 |
raitobezarius | Once every pieces have been touched, the codebase will be formatted. | 13:50:44 |
Charles | Fun fact, clang-format formatting is not stable between versions | 13:54:59 |
Charles | So if you only do it piecemeal then your formatting will probably never actually converge | 13:55:41 |
piegames | Something something eventually consistent | 13:59:23 |
helle (just a stray cat girl) | I love mdbook's look and result, I hate how it gets there..... sigh I may be looking at ways of long term fixing this, so the patchwork of filters that work on raw markdown strings with inconsistencies can go away and I will need to remember to file a bug or two about this | 14:11:19 |
K900 | How the fuck am I code owner | 14:17:49 |
K900 | lol | 14:17:51 |
raitobezarius | In reply to @charles:computer.surgery So if you only do it piecemeal then your formatting will probably never actually converge even a better reason for not doing in one shot then | 14:18:02 |
raitobezarius | because if CI enforces absolute validity, then we will have to reformat on each bumps | 14:18:11 |
raitobezarius | which is a bit ridiculous | 14:18:14 |
Charles | huh? that means you have to do it in one shot, and then reformat on bumps | 14:18:21 |
raitobezarius | In reply to @k900:0upti.me How the fuck am I code owner well you received an email about this cc jade_ :p | 14:18:25 |