| 21 Nov 2025 |
Sergei Zimmerman (xokdvium) | So maybe only do this for attrsets smaller than N, compute a hash of symbol table ids, store it a fixed-sized map and count frequency that way. This shouldn't have much of an overhead | 21:30:50 |
John Ericson | yeah that is in a bitrotted PR | 21:39:29 |
| 22 Nov 2025 |
helle (just a stray cat girl) | glares at lix/nix/prefetch.cc +118 | 11:47:29 |
helle (just a stray cat girl) | erm, why are we making a presumption there, that uh, is not actually also made by nixpkg's fetchzip (which does have stripRoot as an active choice), this with certain use cases, like what npins does, makes it impossible to compute the right hash with it | 11:48:57 |
helle (just a stray cat girl) | (anyway, I don't think it is worth a fix, because of well, yeah) | 12:06:43 |
| adam joined the room. | 17:06:37 |
helle (just a stray cat girl) | has anyone asked about https://docs.lix.systems/manual/lix/stable/contributing/deprecated-features.html#dp-feature-nul-bytes vs https://git.lix.systems/lix-project/lix/src/commit/7e193f962e35217268e81164eef9f8be7059a84e/doc/manual/rl-next/pascal-strings.md because we should figure out how to explain that one in documentation or uh, fix the situation as we now explicitly allow them | 20:18:51 |
helle (just a stray cat girl) | also I think we need to rebuild all the Lix changelogs with anchors, I uh, may be in for some doing I guess, because having anchors is useful | 20:19:37 |
helle (just a stray cat girl) | semi-related screams at the status of the Built-in Functions documentation uhhhh, we need to get some more intelligent arg handling and just combing through and writing all of it to the same standard and potentially some index gen | 21:03:19 |
helle (just a stray cat girl) | given that I can't do much code rn, I may do some doc patches the coming week | 21:03:37 |
helle (just a stray cat girl) | the doc/C++ generator for that also needs some work, so yeah.... | 21:05:18 |
| 23 Nov 2025 |
piegames | In reply to @helle:tacobelllabs.net has anyone asked about https://docs.lix.systems/manual/lix/stable/contributing/deprecated-features.html#dp-feature-nul-bytes vs https://git.lix.systems/lix-project/lix/src/commit/7e193f962e35217268e81164eef9f8be7059a84e/doc/manual/rl-next/pascal-strings.md because we should figure out how to explain that one in documentation or uh, fix the situation as we now explicitly allow them The nul-bytes deprecated feature is about nul bytes in the parser, which as of today still can cause truncation (in the parser, for non-indented strings), whereas the undefined behavior gotcha in terms of eval semantics is now indeed fixed | 07:32:11 |
piegames | I hope that makes sense | 07:32:16 |
helle (just a stray cat girl) | In reply to @piegames:flausch.social The nul-bytes deprecated feature is about nul bytes in the parser, which as of today still can cause truncation (in the parser, for non-indented strings), whereas the undefined behavior gotcha in terms of eval semantics is now indeed fixed I mean I read the code and tests to figure it out (after filing the bug, should ammend it), it made total sense, but if you are not diving that deep, the docs need to be specific enough to explain what is going on there as initially it looks like a conflict | 07:40:12 |
piegames | If you can tackle fixing that that would be appreciated | 09:30:50 |
helle (just a stray cat girl) | okay, will tag you on the patch as I need to make sure to word it right | 09:35:37 |
| 16 May 2024 |
| zrsk joined the room. | 13:54:49 |
samrose | In reply to @lunaphied:lunaphied.me I think there were a few CLs on the Gerrit but nothing being actively worked The other thing that I could do if it helps is test things and try to find bugs. I did do some C++ work in the past, but may lack the time to do it justice here at least for about 30 days or so | 15:55:29 |
Qyriad | we are not in any rush 🙂 | 17:20:53 |
samrose | Would it help to also test out the existing Lix code and try to find issues/bugs etc? | 17:23:21 |
Qyriad | absolutely | 17:23:41 |
samrose |
- how do people feel about the existing test suite that comes along with nix source code or Lix?
| 17:23:48 |
Qyriad | it's pitiful | 17:24:10 |
samrose | heh | 17:24:16 |
raitobezarius | expanding it is cool | 17:24:23 |
raitobezarius | writing new tests for builtins which are not tested | 17:24:30 |
raitobezarius | new test behaviors, etc. | 17:24:32 |
Qyriad | we have three flavors of test:
gtest (offer only available in libexpr and libutil) bash script virtual machine
the vast, vast majority of testing is in the "bash script" flavor and it is a mess | 17:25:01 |
samrose | I was just going to ask on the "functional" tests: do we still like using bash there? | 17:25:56 |
samrose | the last time that I worked on a major nix related cli project that used bash, or bats for testing, over time it became rather kind of hard to maintain | 17:26:42 |