| 21 Jul 2025 |
jade_ | indeed | 22:18:44 |
| 22 Jul 2025 |
jade_ | I don't really want to know what bugs lurk in the trailing padding of the base32 of store path hash parts... | 00:23:32 |
jade_ | I'm sure there's bugs there, since it's unchecked. | 00:23:43 |
jade_ | oh, hash part length is 32 | 00:24:33 |
jade_ | so they delete a char. perfect. | 00:24:39 |
jade_ | * hm. maths. | 00:28:00 |
jade_ | im not doing maths successfully | 00:29:55 |
jade_ | oh. yeah it's not a problem for paths because they're 160 bit and evenly divide by 5 bits. but it is maybe busted for sha256 hashes encoded as base32, in the same way as we know of buggy handling of corrupt padding in base64 SRI hashes that we should probably reject but don't at present. | 00:55:47 |
flokli | @jade_:matrix.org: hash parsing is very broken for the SRI case at least. See the test cases at https://git.snix.dev/snix/snix/src/branch/canon/snix/nix-compat/src/nixhash/mod.rs | 08:57:49 |
flokli | We opted to keep that behavior for now, cause some things in nixpkgs used these strange encodings (probably mostly copy paste errors) | 08:58:26 |
| iggle joined the room. | 15:03:36 |
| Federico Damiรกn Schonborn changed their display name from The Worm ๐ณ๏ธโ๐ (he/they) to Wormy McWormface ๐ณ๏ธโ๐ (he/they). | 18:28:37 |
| j4m3s joined the room. | 18:57:13 |
jade_ | yeah, we have a ticket to generate a warning for it, we've not got to it yet. we would like to be able to get rid of them out of nixpkgs and use our deprecated features functionality to possibly force the issue over a longer time span. | 20:14:47 |
jade_ | (btw if anyone wants to do that ticket it would be awesome!) | 20:15:11 |
jade_ | if anyone was wondering, I have a working demo of this as of today. working on inventing a better open source process at work to be able to release it in a way that's more pleasant, which will take a few weeks.
no blockers to the code itself being released, it's just a pain in the neck to release in a way that's maintainable for us. | 21:01:16 |
| 23 Jul 2025 |
jade_ | currently releasing 2.93.3 | 01:17:12 |
jade_ | * if anyone was wondering, I have a working demo of this as of today at work. working on inventing a better open source process at work to be able to release it in a way that's more pleasant, which will take a few weeks.
no blockers to the code itself being released, it's just a pain in the neck to release in a way that's maintainable for my work. | 01:17:45 |
jade_ | fyi Rutile (Commentator2.0) feel free to ping helle (just a stray cat girl) y'all now have +2 access for directories you are OWNERS of, which currently constitutes doc/ (and any other OWNERS=* files) and tests/.
If there's any omissions in the OWNERS files where you would like to be able to approve for a certain tree, feel free to send a patch.
| 01:22:13 |
jade_ | (this was decided in consultation with the other maintainers, who really like your work as well) | 01:25:12 |
jade_ | 2.93.3 should be out now :) | 01:31:33 |
just1602 | Does the nixos-module need to be updated too, or we should be able to upgrade right away? | 01:33:47 |
jade_ | it does need to get updated indeed. i forget, do you have commit access to that repo? | 05:23:48 |
jade_ | do you want commit access to that repo? | 05:23:58 |
just1602 | I can open PR, and I should have open one now that you ask! | 12:28:43 |
just1602 | In reply to @jade_:matrix.org do you want commit access to that repo? I'm not sure I trust myself enough with the nix experience I have to get commit access on that repo, tho. | 12:30:08 |
raitobezarius | Katalin ๐ช a while ago, you sent us cl/3081 (thank you for that!), sterni just sent us https://gerrit.lix.systems/c/lix/+/3731, the change are very similar ; for now, I assume that we won't need an approach that perform explicit compilation detection, so I'm leaning on proceeding with sterni's change, do you have any opinion on this? | 13:21:31 |
just1602 | https://git.lix.systems/lix-project/nixos-module/pulls/71 | 14:18:19 |
raitobezarius | thanks just1602 finished | 15:05:06 |
raitobezarius | we are just missing a PR in nixpkgs now | 15:05:16 |