| 1 Aug 2025 |
Qyriad | we approved it, so we bear that responsibility too | 17:53:40 |
raitobezarius (DECT: 7248) | we should rerun CI manually on d5cfc6f19c and f077a6f36e | 18:09:44 |
raitobezarius (DECT: 7248) | taking care of it | 18:10:14 |
raitobezarius (DECT: 7248) | In reply to @emilazy:matrix.org I am really confused as to the conflict issues that are being envisioned then. but ok. I will leave it be I double checked again and one reason that I see is that clang-format output is bad in certain (common in the Lix codebase) corner cases | 18:35:29 |
raitobezarius (DECT: 7248) | And this is reason enough to proceed blindly with a full reformat | 18:35:36 |
raitobezarius (DECT: 7248) | * And this is reason enough to not proceed blindly with a full reformat to me | 18:35:41 |
raitobezarius (DECT: 7248) | If being broken on multiple lines with their literals cut in half, call being laid out on multiple lines breaking the logical manual grouping | 18:36:08 |
raitobezarius (DECT: 7248) | We already have some nolint and I remember that we already have troubles with incremental reformatting from time to time but manageable on the scale of it | 18:37:00 |
raitobezarius (DECT: 7248) | All the nested ternaries lose a lot of their meaning | 18:37:13 |
raitobezarius (DECT: 7248) | Also, reformatting is not even nolint-preserving | 18:38:14 |
raitobezarius (DECT: 7248) | So this will cause a lot of manual churn | 18:38:17 |