| 22 Dec 2025 |
raitobezarius | I'm running smoketesting, roberth on your PR, once this passes, I will approve as a Lix code owner | 08:59:09 |
Robert Hensing (roberth) | awesome, thanks! | 08:59:20 |
raitobezarius | thanks for pulling the patch! | 08:59:28 |
helle (just a stray cat girl) | but yes, ty, I read the message like crossways, lol | 09:02:01 |
| @cinerealkiara:matrix.org left the room. | 10:53:47 |
| 23 Dec 2025 |
piegames | Hm. Unfortunately, the Nix language is not amenable to single-parse-pass compilation because of parsetime attrset merging | 09:56:00 |
piegames | Everything else can be done with placeholders and a fixup pass afterwards, but attrsets really require using some treemaps during construction | 09:56:40 |
piegames | Also let's move this over to Zulip https://zulip.lix.systems/#narrow/channel/6-Eval/topic/Parser.20rewrite/with/3389 | 10:36:24 |
XYenon | Should I do anything now, or just wait? My CL hasn't had any new reviews for a week.
https://gerrit.lix.systems/c/lix/+/4783 | 13:44:10 |
piegames | Asking here is fine | 14:10:07 |
piegames | Oh I see, there has been a disagreement between reviewers. Maybe we should escalate it to a core team discusssion then | 14:11:59 |
raitobezarius | where? | 14:15:48 |
piegames | The CL has both +1 and -1 reviews | 14:18:02 |
helle (just a stray cat girl) | is that not just purely for the test impl | 14:18:14 |
raitobezarius | i think you are misreading the reviews | 14:18:13 |
piegames | Or am I reading it wrongly (I'm on the phone so lol@Gerrit UI) | 14:18:19 |
raitobezarius | +1 was given over the F2 part | 14:18:40 |
raitobezarius | -1 was given over the actual contents | 14:18:46 |